Skip to content

fix(action): delete approve workflow as it does not work #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2021
Merged

fix(action): delete approve workflow as it does not work #4453

merged 1 commit into from
Jun 10, 2021

Conversation

dhruvmanila
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@dhruvmanila dhruvmanila requested a review from cclauss as a code owner May 24, 2021 08:24
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels May 24, 2021
cclauss
cclauss approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also change the filename to approve_workflow_run.yml.disabled so don’t need to start over from scratch when the API is finalized.

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 24, 2021
@dhruvmanila
Copy link
Member Author

Let me keep this open for a day or so, I've implemented it in the bot so I will be testing that now.

@dhruvmanila dhruvmanila merged commit daeb6a7 into master Jun 10, 2021
@dhruvmanila dhruvmanila deleted the dhruvmanila-patch-1 branch June 10, 2021 17:18
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@dhruvmanila @shermanhui
fix(action): delete approve workflow as it does not work (TheAlgorith…
8778455 
…ms#4453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
DO-NOT-MERGE enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @cclauss