Skip to content

bin_to_octal #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 19, 2020
Merged

bin_to_octal #2431

merged 7 commits into from
Sep 19, 2020

Conversation

mohammadreza490
Copy link
Contributor

Converts binary values to the octal equivalent.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@mohammadreza490
bin_to_octal
7cf647f 
Converts binary values to the octal equivalent.
@mohammadreza490
Update bin_to_octal
66830ad
cclauss
cclauss reviewed Sep 15, 2020
View reviewed changes
@mohammadreza490 @cclauss
Update conversions/bin_to_octal
cf48d72 
Co-authored-by: Christian Clauss <[email protected]>
realDuYuanChao
realDuYuanChao requested changes Sep 16, 2020
View reviewed changes
Copy link
Member

@realDuYuanChao realDuYuanChao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you rename bin_to_octal to bin_to_octal.py

@mohammadreza490 mohammadreza490 changed the title bin_to_octal bin_to_octal.py Sep 16, 2020
@realDuYuanChao
Copy link
Member

My meaning is rename file bin_to_octal to bin_to_octal.py using below git command

git mv bin_to_octal bin_to_octal.py

realDuYuanChao
realDuYuanChao reviewed Sep 16, 2020
View reviewed changes
@mohammadreza490 mohammadreza490 changed the title bin_to_octal.py bin_to_octal Sep 16, 2020
@mohammadreza490
Copy link
Contributor Author

My meaning is rename file bin_to_octal to bin_to_octal.py using below git command

git mv bin_to_octal bin_to_octal.py

Done

@realDuYuanChao realDuYuanChao merged commit b22596c into TheAlgorithms:master Sep 19, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@mohammadreza490 @cclauss
@realDuYuanChao @stokhos
bin_to_octal (TheAlgorithms#2431)
85a1a5b 
* bin_to_octal

Converts binary values to the octal equivalent.

* Update bin_to_octal

* Update conversions/bin_to_octal

Co-authored-by: Christian Clauss <[email protected]>

* Update conversions/bin_to_octal

Co-authored-by: Du Yuanchao <[email protected]>

* Update conversions/bin_to_octal

Co-authored-by: Du Yuanchao <[email protected]>

* Update conversions/bin_to_octal

Co-authored-by: Du Yuanchao <[email protected]>

* Rename bin_to_octal to bin_to_octal.py

Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Du Yuanchao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realDuYuanChao realDuYuanChao realDuYuanChao approved these changes

@Charlie-xnxx Charlie-xnxx Charlie-xnxx approved these changes

@cclauss cclauss Awaiting requested review from cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohammadreza490 @realDuYuanChao @cclauss @Charlie-xnxx