This repository was archived by the owner on Jun 1, 2023. It is now read-only.
perform some path sanitization over the generated names #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 tasks
The current scheme for the file generation uses the function label, which uses ':' as a parameter separator. However, this character is not valid on all file systems. This results in partial content generation on Windows. Add a sanitization step which replaces "invalid" characters with `_` instead. This does not impact the rendering, only the filenames and the generated URL references between the pages. With this, we can generate and link function documentation on Windows.
compnerd
force-pushed
the
hand-sanitizer
branch
from
12d27b0 to
9211817
Compare
mattt
reviewed
May 5, 2021
mattt
approved these changes
May 5, 2021
|
@compnerd Thanks for your patience on this. Once CI comes back ✅ , I'll merge this in. |
|
@mattt - do I need to redo the patch or can you merge this (for the signing)? |
|
@compnerd Sorry for the delay. This is now merged in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current scheme for the file generation uses the function label,
which uses ':' as a parameter separator. However, this character is not
valid on all file systems. This results in partial content generation
on Windows. Add a sanitization step which replaces "invalid" characters
with
_instead. This does not impact the rendering, only thefilenames and the generated URL references between the pages. With
this, we can generate and link function documentation on Windows.