This repository was archived by the owner on Jun 1, 2023. It is now read-only.
swift-doc: load FoundationNetworking on non-Darwin platforms #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invert the condition to not link against Foundation networking only on non-Darwin platforms. Every other platform uses swift-corelibs-foundation which provides a FoundationNetworking which must be linked against in order to have the networking functionality work. This repairs the fetch of the CSS for Windows hosts.
35 tasks
mattt
reviewed
Apr 26, 2021
Co-authored-by: Mattt <[email protected]>
|
Hmm, what is with the signed commit requirement on this repository? I don't think that I have a setup where configuring that is convenient. I suppose that I could do this through the web editor :/ |
|
@mattt I would be happy to merge, but the signing requirement prevents me from doing it and I can't override it. I think if you'd like all commits in |
|
@MaxDesiatov I'm going to close this as I've opened #265 via the web editor which should allow me to merge. Would you mind approving that? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invert the condition to not link against Foundation networking only on
non-Darwin platforms. Every other platform uses
swift-corelibs-foundation which provides a FoundationNetworking which
must be linked against in order to have the networking functionality
work. This repairs the fetch of the CSS for Windows hosts.