Skip to content

Requesting new build #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PierreLeGuen opened this issue Mar 19, 2019 · 17 comments
Closed

Requesting new build #100

PierreLeGuen opened this issue Mar 19, 2019 · 17 comments

Comments

@PierreLeGuen
Copy link

Hello,
It has been more than 500 commits and 1 year since you didn't published a build.
I'm struggling to build from source, I'm 100% on Linux and .NET apps are quiet frustrating to build.
Thanks in advance,

@stevemk14ebr
Copy link
Contributor

#47

@PierreLeGuen
Copy link
Author

When using msbuild and gcc with mono > 5 :

Extensions/XAttributeExtensions.cs(10,18): error CS8107: Feature 'default literal' is not available in C# 7.0. Please use language version 7.1 or greater. [/home/pierre/Documents/git/ReClass.NET/ReClass.NET/ReClass.NET.csproj]
Done Building Project "/home/pierre/Documents/git/ReClass.NET/ReClass.NET/ReClass.NET.csproj" (default targets) -- FAILED.

Build FAILED.

"/home/pierre/Documents/git/ReClass.NET/ReClass.NET/ReClass.NET.csproj" (default target) (1) ->
(CoreCompile target) -> 
  Extensions/XAttributeExtensions.cs(10,18): error CS8107: Feature 'default literal' is not available in C# 7.0. Please use language version 7.1 or greater. [/home/pierre/Documents/git/ReClass.NET/ReClass.NET/ReClass.NET.csproj]

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:01.52

When changing langVersion in csproj to 7.3 it still doesn't build.

@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 19, 2019

What error do you get with C# 7.3?

@PierreLeGuen
Copy link
Author

After changing from <LangVersion>lastest</LangVersion> to <LangVersion>7.3</LangVersion>.
I get the same error

Extensions/XAttributeExtensions.cs(10,18): 
error CS8107: Feature 'default literal' is not available in C# 7.0. Please use language version 7.1 or greater. 
[/home/pierre/Documents/git/ReClass.NET/ReClass.NET/ReClass.NET.csproj]

Done Building Project "/home/pierre/Documents/git/ReClass.NET/ReClass.NET/ReClass.NET.csproj" (default targets) --
 FAILED.

Btw I tested on two laptops and it happens every time. Thanks for your time.

@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 19, 2019

<LangVersion>lastest</LangVersion> is the latest version available (7.3). As you see in the error message C# 7.0 is used. Maybe Mono doesn't support newer versions?

@stevemk14ebr
Copy link
Contributor

As an aside, it sounds like time for some continuous integration tooling to be added to the repo

@PierreLeGuen
Copy link
Author

@KN4CK3R Mono does support C# 7.3 since mid 2018 (mono 5.0.0):

image

Maybe it's still missing some features?

@stevemk14ebr I think you right, it could be done pretty easily with Travis CI as an app on github.

@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 20, 2019

Disclaimer: I have no Mono knowlegde.
csc is the Mono compiler for .NET Core. But ReClass.NET isn't a .NET Core project (yet (I'm waiting for the .NET Core 3 release with WinForms support #73)). The makefile uses the msbuild compiler which may not support C# 7.3 (mono/mono#6854). To be able to build again, you need to revert this commit efdf372. Maybe I will stick to C# 7.0 until the project is converted to .NET Core.

@PierreLeGuen
Copy link
Author

After reversing to efdf372. The error is even bigger.
I've no idea why it happens... Maybe not supported yet ?

UI/EnumComboBox.cs(11,60): error CS8107: Feature 'enum generic type constraints' is not available in C# 7.0. Please use language version 7.3 or greater. [/home/pierre/Documents/git/ReClass.NET-efdf3729f7c74256b9be0888515711a6f39da514/ReClass.NET/ReClass.NET.csproj]
Memory/RemoteProcess.cs(209,58): error CS8107: Feature 'unmanaged generic type constraints' is not available in C# 7.0. Please use language version 7.3 or greater. [/home/pierre/Documents/git/ReClass.NET-efdf3729f7c74256b9be0888515711a6f39da514/ReClass.NET/ReClass.NET.csproj]
Memory/RemoteProcess.cs(572,71): error CS8107: Feature 'unmanaged generic type constraints' is not available in C# 7.0. Please use language version 7.3 or greater. [/home/pierre/Documents/git/ReClass.NET-efdf3729f7c74256b9be0888515711a6f39da514/ReClass.NET/ReClass.NET.csproj]
Memory/MemoryBuffer.cs(160,51): error CS8107: Feature 'unmanaged generic type constraints' is not available in C# 7.0. Please use language version 7.3 or greater. [/home/pierre/Documents/git/ReClass.NET-efdf3729f7c74256b9be0888515711a6f39da514/ReClass.NET/ReClass.NET.csproj]
Memory/MemoryBuffer.cs(167,48): error CS8107: Feature 'unmanaged generic type constraints' is not available in C# 7.0. Please use language version 7.3 or greater. [/home/pierre/Documents/git/ReClass.NET-efdf3729f7c74256b9be0888515711a6f39da514/ReClass.NET/ReClass.NET.csproj]
UI/EnumDescriptionDisplay.cs(11,59): error CS8107: Feature 'enum generic type constraints' is not available in C# 7.0. Please use language version 7.3 or greater. [/home/pierre/Documents/git/ReClass.NET-efdf3729f7c74256b9be0888515711a6f39da514/ReClass.NET/ReClass.NET.csproj]
Done Building Project "/home/pierre/Documents/git/ReClass.NET-efdf3729f7c74256b9be0888515711a6f39da514/ReClass.NET/ReClass.NET.csproj" (default targets) -- FAILED.

Build FAILED.

MSBuild version

> msbuild -V                                                                                                                               
Microsoft (R) Build Engine version 16.0.0.0 for Mono
Copyright (C) Microsoft Corporation. All rights reserved.

@PierreLeGuen
Copy link
Author

I just tried the commit 779cb2e and it compiles.
Hoping .NET Core 3 release with WinForms soon

@KN4CK3R
Copy link
Member

KN4CK3R commented Mar 21, 2019

You shouldn't reverse to efdf372 but undo the changes that were made in this commit. After you have done this you can use the lastest source (minus this commit).

KN4CK3R added a commit that referenced this issue Mar 31, 2019
KN4CK3R added a commit that referenced this issue Mar 31, 2019
@joaoescribano
Copy link

To be true, I've tried a lot.. and a lot to compile it.. it simply doesn't compile at any circumstances under mono in ubuntu 18.04.

I already have mono 5+, nuget (installed by apt, also .exe through mono nuget.exe) to install dependencies (like SQLite) and nothing, absolutely nothing makes it compile...

It would be awesome if a new release been published.

Note:
Also, the old release doesn't run under mono.

@KN4CK3R
Copy link
Member

KN4CK3R commented Apr 13, 2019

After fixing 3162e04 I was able to compile the project with Mono 5.20 without problems. Try it out!

VirtualBox_Lubuntu_13_04_2019_23_39_21

@KN4CK3R
Copy link
Member

KN4CK3R commented Apr 15, 2019

I released ReClass.NET 1.2 for you.

@KN4CK3R KN4CK3R closed this as completed Apr 15, 2019
@joaoescribano
Copy link

Thanks so much, i'll try as soon i get home :)

Thanks

@joaoescribano
Copy link

I could not stand to wait... haha

image

Seems working, I'll try to use as soon I get home.. o just had to see it working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@joaoescribano @KN4CK3R @stevemk14ebr @PierreLeGuen and others