Use new isTransient API to prevent duplicate integrated consoles
#3854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
This new API available today in VS Code 1.65.0 prevents Code from saving and reloading the integrated console when the extension is reloaded. This is necessary because the extension always spawns a new terminal to host PowerShell Editor Services when it starts, and Code's newish feature to save and restore terminals caused these to be duplicated. When we update the VS Code engine, we can remove the cast to `any`.
andyleejordan
force-pushed
the
andschwa/isTransient
branch
from
1b832e1 to
fa8ff74
Compare
andyleejordan
changed the title
isTransient featureisTransient API to prevent duplicate integrated consoles
|
@SeeminglyScience I tested and the cast as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new API available today in VS Code 1.65.0 prevents Code from saving
and reloading the integrated console when the extension is reloaded.
This is necessary because the extension always spawns a new terminal to
host PowerShell Editor Services when it starts, and Code's newish
feature to save and restore terminals caused these to be duplicated.
When we update the VS Code engine, we can remove the cast to
any.Fixes #3360.