Add magic marker to specifyScriptArgs to disable argument escaping
#3819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coupled with a change to PSES, this enables us to workaround VS Code's API limitations where our interactive "get user's arguments" command can only return a string, not an array of strings, which is then passed as a single argument to PSES. Because it likely contains spaces (and multiple arguments), we need to instruct PSES to not quote the string in this special case. It would be easier if we could just pass a list of string arguments, but so it goes.
ghost
added
|
We're going to fix this by reverting the argument escaping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coupled with a change to PSES, this enables us to workaround VS Code's
API limitations where our interactive "get user's arguments" command can
only return a string, not an array of strings, which is then passed as a
single argument to PSES. Because it likely contains spaces (and multiple
arguments), we need to instruct PSES to not quote the string in this
special case. It would be easier if we could just pass a list of string
arguments, but so it goes.
Coupled with PowerShell/PowerShellEditorServices#1702, this fixes #3770.