Skip to content

Setting to Disable Pester Code Lens #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2021
Merged

Setting to Disable Pester Code Lens #3613

merged 3 commits into from
Oct 18, 2021

Conversation

JustinGrote
Copy link
Collaborator

@JustinGrote JustinGrote commented Oct 13, 2021

Allows the Pester Codelens to be disabled so as not to confuse users who want to use an alternate Pester Test Runner

Correlated PSES PR: PowerShell/PowerShellEditorServices#1585

Resolves #3430

PR Summary

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@ghost ghost added the Issue-Enhancement A feature request (enhancement). label Oct 13, 2021
@JustinGrote JustinGrote changed the title feat: Disable Pester Code Lens feat: Disable Pester Code Lens Setting Oct 13, 2021
@JustinGrote JustinGrote changed the title feat: Disable Pester Code Lens Setting Disable Pester Code Lens Setting Oct 13, 2021
@JustinGrote JustinGrote changed the title Disable Pester Code Lens Setting Setting to Disable Pester Code Lens Oct 13, 2021
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, we should add a high-level test here that asserts the CodeLens are (and are not) correctly enabled on Pester test files.

JustinGrote and others added 2 commits October 13, 2021 10:07
Co-authored-by: Andy Schwartzmeyer <[email protected]>
Co-authored-by: Andy Schwartzmeyer <[email protected]>
@andyleejordan
Copy link
Member

Sorry about the 5.1 failure, it's still flaky but I also think the "can start Pester tests from file (which also tests debugger)" test is really freaking important.

@JustinGrote
Copy link
Collaborator Author

I got the Pester setting issue sorted, no idea why a direct assignment didn't work but implementing an Update method did.

@JustinGrote
Copy link
Collaborator Author

@andschwa works as expected now
Capture
.

@JustinGrote
Copy link
Collaborator Author

PowerShell/PowerShellEditorServices#1585 has now been merged, this is required to complete the feature.

@andyleejordan andyleejordan merged commit 4964cea into PowerShell:master Oct 18, 2021
@JustinGrote JustinGrote deleted the JustinGrote/disablePesterCodeLensSetting branch October 29, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Pester Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Pester CodeLens
3 participants