Replace TSLint with ESLint #3331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Build & Release
Issue-Enhancement
andyleejordan
commented
May 3, 2021
andyleejordan
force-pushed
the
andschwa/eslint
branch
from
cc1b3a2 to
e945af7
Compare
andyleejordan
changed the title
Since we use it intentionally, and now only at 99 problems!
Ignoring bitwise and console as they're not warnings.
andyleejordan
force-pushed
the
andschwa/eslint
branch
from
f588af4 to
b0b729a
Compare
|
@SeeminglyScience for what it's worth there is also |
Except where we have to ignore them individually.
We selectively fixed and enabled most of its warnings, and then disabled the ones we cannot (for now) fix (mostly due to use of `any`).
|
Ok I turned that on! |
|
Followed this essentially: https://typescript-eslint.io/docs/linting/configs/ |
andyleejordan
force-pushed
the
andschwa/eslint
branch
from
333b8a7 to
d74b328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The originally recommended migration method resulted in 3,150 problems, and it moved us to an already out-of-date version of ESLint. So I decided to redo this by moving natively to ESLint's recommended configuration (no TSLint migration, except for comment directives) and then allowed ESLint to reformat the codebase. Resolves #2882.