OneBranch now uses PowerShell 7.4 so remove workarounds #2218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can rely on the pre-installed PSResourceGet and we can re-enable tests!
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.pipelines/PowerShellEditorServices-Official.yml:91
- Verify that the installPSResources.ps1 script now encapsulates all needed actions (registration of the PS repository and installation of PSResourceGet), since the explicit commands have been removed.
- - pwsh: ./tools/installPSResources.ps1 -PSRepository CFS
.pipelines/PowerShellEditorServices-Official.yml:93
- [nitpick] Consider updating the displayName accompanying this step so that it accurately reflects the action being performed, given the change from 'Build' to 'TestFull'.
+ - pwsh: Invoke-Build TestFull -Configuration $(BuildConfiguration) -PSRepository CFS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can rely on the pre-installed PSResourceGet and we can re-enable tests!
@JustinGrote seriously we can finally run tests again in the release pipeline 🤞