Skip to content

Temporarily disable IsDebuggerCommand check #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Temporarily disable IsDebuggerCommand check #1763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/PowerShellEditorServices/Services/PowerShell/Execution/SynchronousPowerShellTask.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public SynchronousPowerShellTask(

// These are PowerShell's intrinsic debugger commands that must be run via
// `ProcessDebugCommand`.
private static readonly string[] DebuggerCommands = { "continue", "c", "k", "h", "?", "list", "l", "stepInto", "s", "stepOut", "o", "stepOver", "v", "quit", "q", "detach", "d" };
// TODO: private static readonly string[] DebuggerCommands = { "continue", "c", "k", "h", "?", "list", "l", "stepInto", "s", "stepOut", "o", "stepOver", "v", "quit", "q", "detach", "d" };

public override IReadOnlyList<TResult> Run(CancellationToken cancellationToken)
{
Expand All @@ -66,7 +66,7 @@ public override IReadOnlyList<TResult> Run(CancellationToken cancellationToken)
}

return _pwsh.Runspace.Debugger.InBreakpoint
&& (IsDebuggerCommand(_psCommand) || _pwsh.Runspace.RunspaceIsRemote)
// TODO: && (IsDebuggerCommand(_psCommand) || _pwsh.Runspace.RunspaceIsRemote)
? ExecuteInDebugger(cancellationToken)
: ExecuteNormally(cancellationToken);
}
Expand All @@ -78,6 +78,7 @@ public override IReadOnlyList<TResult> Run(CancellationToken cancellationToken)

public override string ToString() => _psCommand.GetInvocationText();

/* TODO: Make this fix actually work.
private static bool IsDebuggerCommand(PSCommand command)
{
if (command.Commands.Count is not 1
Expand All @@ -97,6 +98,7 @@ private static bool IsDebuggerCommand(PSCommand command)

return false;
}
*/

private IReadOnlyList<TResult> ExecuteNormally(CancellationToken cancellationToken)
{
Expand Down