Implemented -LanguageServiceOnly switch. #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkattan
force-pushed
the
feature/lsp-only-switch
branch
2 times, most recently
from
c322aeb to
1d531ff
Compare
dkattan
force-pushed
the
feature/lsp-only-switch
branch
from
1d531ff to
477f08b
Compare
|
Hey @andschwa would you mind reviewing this and getting it merged? |
|
@JustinGrote Would you mind reviewing this? |
andyleejordan
approved these changes
Dec 10, 2021
src/PowerShellEditorServices.Hosting/Commands/StartEditorServicesCommand.cs
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
December 10, 2021 13:05
Head branch was pushed to by a user without write access
|
Looks like there's some sort of transient error on MacOS. I made a small change to re-trigger CI which invalidated auto-merge. Evidently CI re-runs automatically and when it did all checks passed:
Anyway, @andschwa you'll likely need to merge it when you get back from vacation |
|
Hey @andschwa I pushed a commit and invalidated your auto-merge. Can you get this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where the Debug server is not necessary, it is not possible to shutdown PSES as it hangs here:
PowerShellEditorServices/src/PowerShellEditorServices.Hosting/Internal/EditorServicesRunner.cs
Line 186 in 96a8207