Skip to content

VSCode PowerShell Integrated Console hangs when running PSReadLine 2.2.0-beta3 #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alialo opened this issue Jul 3, 2021 · 3 comments
Closed
Labels
Area-Startup Issue-Bug A bug to squash. Resolution-Answered Will close automatically.

Comments

@alialo
Copy link

alialo commented Jul 3, 2021

VSCode PowerShell extension release v2020.4.1-preview or newer causes the integrated console to hang when attempting to run code if PSReadLine 2.2.0-beta3 is installed. The only changes introduced in v2020.4.1-preview are related to PowerShellEditorServices so I've raised the issue here and closed the existing one (can be found here for reference).

It appears to be related to pull 1255. Removing PSReadLine 2.2.0-beta3 and reverting back to beta2 fixes the problem, as does rolling back the extension to v2020.4.0-preview or older.

@andyleejordan
Copy link
Member

Wow, thanks for the investigation! That's super interesting because we just recently traced an issue in PSReadLine 2.2.0-beta3 itself that caused more problems: PowerShell/PSReadLine#2616 I'm wondering how this interaction played out.

@brwilkinson
Copy link

subscribe.

@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Jul 12, 2021
@andyleejordan
Copy link
Member

So I think the way this played out is that in the rework in #1255, PSES started using a linked cancellation token in PSReadLine to run correctly and asynchronously, but in beta3 of PSReadLine, the cancellation token was erroneously being dropped for an unlinked default token, which has now been fixed in PowerShell/PSReadLine#2636.

@andyleejordan andyleejordan added Area-Startup Issue-Bug A bug to squash. Resolution-Answered Will close automatically. and removed Needs: Maintainer Attention Maintainer attention needed! Needs: Triage Maintainer attention needed! labels Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Startup Issue-Bug A bug to squash. Resolution-Answered Will close automatically.
Projects
None yet
Development

No branches or pull requests

3 participants