upgrading from 2.2.0-beta2 > beta3 broke Powershell debugger in vscode

[bchap1n]

Environment

PS version: 7.1.3
PSReadline version: 2.2.0-beta3
os: 10.0.19041.1 (WinBuild.160101.0800)
PS file version: 7.1.3.0
HostName: Visual Studio Code Host
BufferWidth: 238
BufferHeight: 10

Exception report

Steps to reproduce

Upgrade to PSReadline 2.2.0-beta3 from PSReadline 2.2.0-beta2
Open new PowerShell script in VSCode, set breakpoint on first line, and launch debugger

This happens in latest vscode and vscode-insiders, Powershell/Powershell-Insiders Extension and with Powershell 7.1+ and 7.2+

Expected behavior

debugger should pause at the breakpoint

Actual behavior

debugger just hangs and I can either pause or stop

notes

I tried rolling back powershell extension, and rebooting.

[WorrenB]

seems to be related to PSReadLine 2.2.0-beta 3 breaks extension
in my case I couldn't use F8 (Run Selections) either

[andyleejordan]

@bchap1n and @WorrenB Can you please downgrade your PSReadLine to the latest compatible version (i.e. the one we ship with the extension) 2.1.0?

PowerShell/vscode-powershell#3393 (comment)

[bchap1n]

@andschwa 2.1.0 and 2.2.0-beta2 both work ok for me.

The problem is that I can't use Powershell Preview 7.2.* at all without PSReadline 2.2.0-beta3 and there is no work-around for that.

[andyleejordan]

The fix is going to be PowerShell/PowerShellEditorServices#1514

[andyleejordan]

Unless, @daxian-dbw, will PowerShell Preview 7.2.x be incompatible with PSReadLine 2.1.0 at some point? Like, what's our priority to upgrade the bundled PSReadLine to 2.2.0?

[bchap1n]

@andschwa I see your question was directed at dbw but I understand that PowerShell Preview 7.2.0-preview.7 is not compatible with PSReadLine 2.1.0

[andyleejordan]

Hm, FYI @rjmholt we might have to prioritize bumping PSReadLine.

[daxian-dbw]

will PowerShell Preview 7.2.x be incompatible with PSReadLine 2.1.0 at some point? Like, what's our priority to upgrade the bundled PSReadLine to 2.2.0?

Yes, 2.1.0 works with all 7.2 preview releases. It's safe to bundle PSES with 2.1.0 PSReadLine.

[daxian-dbw]

@rjmholt found out the root cause why 2.2.0-beta3 breaks VSCode debugging:

PSReadLine/PSReadLine/ReadLine.cs

Lines 317 to 320 in ad74cef

	public static string ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken)
	{
	return ReadLine(runspace, engineIntrinsics, _defaultCancellationToken, lastRunStatus: null);
	}

The cancellationToken should be passed along instead of using the default token. PR is out: #2636

[ghost]

🎉 This issue was addressed in 2636, which has now been successfully released in v2.2.0-beta4. 🎉