-
Notifications
You must be signed in to change notification settings - Fork 49
Quoted strings/here-strings issues #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
permits whitespace to follow here-string start token.
Just added item 4. These items could use to have tests added when they are fixed (1,2a and 4). Would need to determine what that scope should be for item 4. While I have commits for fixes/improvements, I'll hold off on a PR until given direction on combining #143, this issue (all 4 parts), and maybe #141. For instances, items 2 and 3 make #141 easier to implement. Do I combine them (but each committed separately) because they cover the same lines (or very close) or do I create PR's for each but incrementally creating each new branch from the previous one? |
Thinking about it some more,
Maybe its best in the end to just put them all in one PR? |
permits whitespace to follow here-string start token.
adds punctuation scope to start/end of here-string
permits whitespace to follow here-string start token.
indirectly applies PowerShell#167 parts 2 and 3
adds punctuation scope to start/end of here-string
Adding to issue #143,
@
not highlighted, because regular quoted string still fires, but if any further quotes are used in the here-string, they will cause highlighting issues.'hello there
.(a) This statement highlights incorrectly because the begin regex incorrectly requires a match of a single-quote to which is not preceded by single-quote. This is flawed because the previous single-quote could be backticked. In reality the check for a prior single-quote is unneeded.
(b) Likewise the end regex requires matching a single quote not followed by another single quote, but this requirement can be eliminated by using the TextMate
applyEndPatternLast
property, setting it totrue
.(b) The end match for double-quoted strings can benefit from the same property as the single-quoted string.
NOTE: these are relatively minor issues overall.
The text was updated successfully, but these errors were encountered: