Skip to content

Add executors post #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 31, 2020
Merged

Add executors post #10

merged 5 commits into from
Aug 31, 2020

Conversation

shrijitsingh99
Copy link
Contributor

First draft
Missing some sections and formatting

kunaltyagi
kunaltyagi requested changes Aug 31, 2020
View reviewed changes
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update with grammar

@shrijitsingh99
Copy link
Contributor Author

Update with grammar

Have passed it through Grammarly, I write there itself now 😄

aPonza
aPonza reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@aPonza aPonza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized afterwards it's still a draft. Might be useful nonetheless.

SergioRAgostinho
SergioRAgostinho reviewed Aug 31, 2020
View reviewed changes
@shrijitsingh99 shrijitsingh99 marked this pull request as ready for review August 31, 2020 10:22
kunaltyagi
kunaltyagi reviewed Aug 31, 2020
View reviewed changes
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a final few finishing touches and it'd be good to go

kunaltyagi
kunaltyagi reviewed Aug 31, 2020
View reviewed changes
@kunaltyagi
Copy link
Member

1 conflict

SergioRAgostinho
SergioRAgostinho approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase with master to update to the new folder structure.

@kunaltyagi kunaltyagi merged commit 3c2443e into PointCloudLibrary:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aPonza aPonza aPonza left review comments

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@kunaltyagi kunaltyagi kunaltyagi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shrijitsingh99 @kunaltyagi @SergioRAgostinho @aPonza