Skip to content

fix: corrected setup for blockESLintPlugin #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 9, 2025

PR Checklist

Overview

Switches the default README.md usage to a defaultUsage Addon, then pipes blockTypeScript's example files through blockExample. That way --exclude-example-files gets them out of the way so that --add-eslint-plugin can swap in the eslint-doc-generator table.

🎁

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@JoshuaKGoldberg JoshuaKGoldberg merged commit afc398b into main Apr 9, 2025
14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the block-eslint-plugin-setup branch April 9, 2025 15:22
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.80%. Comparing base (6062f49) to head (b49a201).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/blocks/blockREADME.ts 66.66% 1 Missing ⚠️
src/options/readReadmeUsage.ts 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2196      +/-   ##
==========================================
- Coverage   99.83%   99.80%   -0.04%     
==========================================
  Files         135      134       -1     
  Lines        5971     6001      +30     
  Branches      497      499       +2     
==========================================
+ Hits         5961     5989      +28     
- Misses         10       12       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Apr 9, 2025

🎉 This is included in version v2.40.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: ESLint failures creating a new repo with blockESLintPlugin
1 participant