Skip to content

Convert the toc into sequential text #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rashikawat
Copy link

The order of the table of contents was all over the place, so I fixed it so that I could read them in order.
I also categorized each book by the main headings that were in the mind map.

@rashikawat rashikawat requested a review from yuhattor as a code owner May 9, 2025 09:03
Copy link

welcome bot commented May 9, 2025

Thank You Banner

💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.

If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁

  • Confirm that you have used our pattern template. Please remove any placeholder text and sections that your pattern did not need.
  • We run a number of automated checks on your PR. Please review the output of those checks on the PR itself, and see if any issues got flagged that you can fix yourself.
  • Make sure you have added your new pattern to the list of patterns in the main README.md. If you are unsure where to add your pattern, just let us know by commenting on your PR and we will help you.

This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

@rashikawat rashikawat marked this pull request as draft May 9, 2025 09:05
@rashikawat rashikawat marked this pull request as ready for review May 9, 2025 09:07
@rashikawat rashikawat marked this pull request as draft May 9, 2025 09:07
@spier
Copy link
Member

spier commented May 9, 2025

Thank you @rashikawat for trying to improve the discoverability of the Japanese pattern translations.

The TOC is actually autogenerated programmatically. So if we want to change the order in there, we would have to change some scripts etc.

Interesting idea to create a different pattern grouping. Maybe we could express that in a markmap mindmap as well, if it should not work in the TOC directly.

@yuhattor could you help with this PR, as I cannot review the Japanese content that well ;)

FYI I have limited internet access at the moment, so further input from me will take some weeks.

@rashikawat
Copy link
Author

@spier Thanks for your comment!

Yes, what I wanted to do was to change the entire table of contents accordingly, since the current mind map is displayed as images and it is not possible to follow links to each pattern.
Also, the mind map has not yet been translated into Japanese.

So, rather than taking an approach of dynamically creating the list with a script, I decided to fix it and make it a static order for reading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants