Skip to content

Allow SQL functions to inline in the presence of costly parameter functions #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Allow SQL functions to inline in the presence of costly parameter functions #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/backend/optimizer/util/clauses.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4545,7 +4545,7 @@ inline_function(Oid funcid, Oid result_type, Oid result_collid,
else if (usecounts[i] != 1)
{
/* Param used multiple times: uncool if expensive or volatile */
QualCost eval_cost;
// QualCost eval_cost;

/*
* We define "expensive" as "contains any subplan or more than 10
Expand All @@ -4555,10 +4555,10 @@ inline_function(Oid funcid, Oid result_type, Oid result_collid,
*/
if (contain_subplans(param))
goto fail;
cost_qual_eval(&eval_cost, list_make1(param), NULL);
if (eval_cost.startup + eval_cost.per_tuple >
10 * cpu_operator_cost)
goto fail;
// cost_qual_eval(&eval_cost, list_make1(param), NULL);
// if (eval_cost.startup + eval_cost.per_tuple >
// 10 * cpu_operator_cost)
// goto fail;

/*
* Check volatility last since this is more expensive than the
Expand Down