Skip to content

allow setting AZURE_OPENAI_LOCATION in env #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

hund030
Copy link
Contributor

@hund030 hund030 commented Aug 26, 2024

Purpose

Unblock azd up --no-prompt by setting AZURE_OPENAI_LOCATION in env.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Type of change

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

N/A

  • PF tested with a brand new env, it still prompts for location in that case.

@pamelafox
Copy link
Contributor

Thanks! I tested this with a brand new env, and it does still prompt for location in that case, since it has no default value, so this works. Thanks! Feel free to send same PR for other repos if they are blocked in th same way.

@pamelafox pamelafox merged commit 0fa5fca into Azure-Samples:main Aug 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants