Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Add Custom Speech integration to SDK and sample #82

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mikebranstein
Copy link

The SDK did not previously allow for testing of the Custom Speech service using the Speech WebSocket protocol. This adds an option to select the Bing Speech API or the Custom Speech API. It uses the new Custom Speech API endpoint URLs, published after //BUILD 2018.

@msftclas
Copy link

msftclas commented May 18, 2018

CLA assistant check
All CLA requirements met.

@compulim
Copy link

If there is no changes in package.json, there should be no changes in package-lock.json.

If their package-lock.json is outdated for some reasons, should split this change into another PR focusing on that topic.

The PR looks great IMO.

@mikebranstein
Copy link
Author

Thank you, @compulim. I've corrected the package-lock.json issue, removing my unintended changes.

@mattiagecchele
Copy link

Can you close this PR ASAP? We need the custom endpoint

@unsafecode
Copy link

+1

@tjoudeh
Copy link

tjoudeh commented Sep 15, 2018

Hello @mikebranstein @compulim is there any reason this PR is not completed yet? It is blocking using the new unified speech service in bot framework WebChat, right? I hope you can follow up on this internally with the team to look into it and complete it.

@compulim
Copy link

@tjoudeh I am not the owner of this repo and not a member of Cognitive Services team, so I cannot approve/merge this PR. 😔 I also hope to see it coming in asap.

@mikebranstein
Copy link
Author

@tjoudeh I am also not the owner, nor Microsoft. I work for a MSFT partner that has been using this extensively, so I'd love to see the changes merged.

Perhaps @RaviPidaparthi could help us find the owner.

@msimecek
Copy link

msimecek commented Sep 20, 2018

@zhouwangzw Could you please check?

@npacucci
Copy link

Any news??? @WSturman. It's possible to merge this?

@vippatel90
Copy link

@WSturman , @mikebranstein any news?? why this is not being merged?

@mikebranstein
Copy link
Author

@viananth I am not the owner of this repo, and not a Microsoft employee. I cannot merge, unfortunately. @WSturman and @wolfma61 - perhaps you can facilitate this merge. It looks like you've made the most recent commits.

@EricDahlvang
Copy link

Can we get this merged please?

@WSturman
Copy link
Contributor

WSturman commented Nov 7, 2018

This sample is for Bing Speech, which is retiring. We have a JavaScript sample for the new Speech Service at https://github.com/Azure-Samples/cognitive-services-speech-sdk/tree/master/samples/js/browser.

@Kartik1607
Copy link

Kartik1607 commented Nov 28, 2018

@WSturman Hi. I was wondering how to implement the endpoint from cris.ai for my custom speech. There is method SpeechConfig.fromEndpoint which accepts a url and subscription key, but there is no mention from where we can get that url. Is it the websocket URL, or REST url?

@erhopf
Copy link

erhopf commented Nov 28, 2018

@Kartik1607 - I think you're looking for the REST endpoints listed in the Swagger Spec: https://westus.cris.ai/swagger/ui/index. Please select v2 from the drop-down, as the details you're looking for may not be available in Beta.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.