Update Binaryen and utilize new ExpressionRunner API #1237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses Binaryen's new ExpressionRunner that we have been waiting for to continue work on #1111. Overall this works well and
untouched
output is much more true to the source now since we no longer have to precompute conditions, but can instead drop them once we evaluated their outcome.But: There's one remaining issue as can be seen on the failing
std/typedarray
test, where it fails to evaluate expressions likedue to bailing early when encountering a
local.get
with an unknown value, here breaking statically precomputedinstanceof
. A bit unfortunate, but going to look into this.