-
-
Notifications
You must be signed in to change notification settings - Fork 80
feat: Add new Prometheus target and metadata API endpoints #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add four new methods to PrometheusConnect class: - get_scrape_pools(): Retrieve list of unique scrape pool names - get_targets(): Get active/dropped targets with optional state and pool filters - get_target_metadata(): Fetch metadata about metrics from specific targets - get_metric_metadata(): Get metadata about metrics with optional filtering These additions provide better visibility into Prometheus targets and metric metadata, enabling more detailed monitoring and configuration analysis.
@RiviaAzusa this looks great but could you please add tests for these new functions? |
I have submitted the test cases, please review them and point out any errors if there are any. |
|
modified: tests/test_prometheus_connect.py
I have fixed the related bugs, please review again. |
4n4nd
approved these changes
Apr 18, 2025
Thank you @RiviaAzusa! |
You are welcome @4n4nd ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add four new methods to PrometheusConnect class:
These additions provide better visibility into Prometheus targets and metric
metadata, enabling more detailed monitoring and configuration analysis.