Skip to content

Causes all files in node_modules to be linted #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jacksteamdev opened this issue Jun 23, 2017 · 12 comments
Closed

Causes all files in node_modules to be linted #64

jacksteamdev opened this issue Jun 23, 2017 · 12 comments

Comments

@jacksteamdev
Copy link

Recently I've noticed that I'm getting a lot of items under the Problems tab in VS Code. All of the files are in node_modules.

Disabling all extensions eliminates these items, and enabling "IntelliSense for CSS class names" causes the items to reappear. Enabling all extensions except "IntelliSense for CSS" once again eliminates these items.

Is this the intended behavior?

@stephen-nba
Copy link

I found the same thing. Is this extension supposed to lint all my CSS as well? Even in the node_modules folder?

@marcelo-mason
Copy link

marcelo-mason commented Jul 2, 2017

An option to exclude paths from showing problems would be nice. I may want intellisense from vendor folders, but I don't care about the problems it finds in there, they are not for me to fix.

@imaia
Copy link

imaia commented Jul 6, 2017

My VS code freezes and crashes with this extension. I'm quite sure this issue problem is related to it. I starts looking for css classes and crashes.

@gobijan
Copy link

gobijan commented Jul 12, 2017

VS Code also freezes for me caused by this extension

@bgarrant
Copy link

I am having the same issue. How can we exclude folders?

@Chanran
Copy link

Chanran commented Jul 21, 2017

my vs code crash too! all node_modules css files lint and cause 99 warns and 99 errors.

@bwcgn
Copy link

bwcgn commented Aug 2, 2017

i just excluded node_modules completely.

files.exclude: {
        "**/.git": true,         
        "**/.DS_Store": true, 
        "**/node_modules": true
}

Repository owner deleted a comment from bgarrant Aug 20, 2017
Repository owner deleted a comment from phifa Aug 20, 2017
Repository owner deleted a comment from bgarrant Aug 20, 2017
Repository owner deleted a comment from reflog Aug 20, 2017
Repository owner deleted a comment from ikzjfr0 Aug 20, 2017
Repository owner deleted a comment from mcleanra Aug 20, 2017
@fgeierst
Copy link

The following prevents node_modules folders to get linted:

User settings

"files.exclude": {
        "**/.git": true,         
        "**/.DS_Store": true, 
        "**/node_modules": true
}

This said, I still think the extention should ignore node_modules folders by default.

@Luca-Terrazzan
Copy link

Excluding the node_modules also prevents it from showing up in vscode entirely...what if I want to browse it from time to time? An option to exclude path from the plugin is necessary imho

@rkpatel33
Copy link

+1

For me the files.exclude option is not ideal. A package specific setting would be better I think.

@zignd
Copy link
Owner

zignd commented Dec 27, 2017

The recently released version adds a feature that is supposed to solve this issue.

@zignd zignd closed this as completed Dec 27, 2017
@bardware
Copy link

The following prevents node_modules folders to get linted

I hoped for that but I'm not sure it works. My project is very small, the node_modules folder, however, is large. VSCode takes it's time to start up because of this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests