Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit 635e0e4

Browse files
committed
#8 fixed test-assertions after reading the spec
minimal valid auth would contain only a semicolon (no user-id or password) that makes some of the test assertions that i thought be invalid actually valid. Move them accordingly.
1 parent f739237 commit 635e0e4

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

test/BasicAccessTest.php

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -157,13 +157,8 @@ public function provideInvalidAuthenticationHeader(): array
157157
return [
158158
'empty-header' => [[]],
159159
'missing-basic-prefix' => [['foo']],
160-
'only-username' => [['Basic ' . base64_encode('Aladdin')]],
161-
'username-with-colon' => [['Basic ' . base64_encode('Aladdin:')]],
162-
'password-without-username' => [['Basic ' . base64_encode(':OpenSesame')]],
160+
'only-username-without-colon' => [['Basic ' . base64_encode('Aladdin')]],
163161
'base64-encoded-pile-of-poo-emoji' => [['Basic ' . base64_encode('💩')]],
164-
'password-containing-colon' => [['Basic ' . base64_encode('username:password:containing:colons:')]],
165-
'only-one-colon' => [['Basic ' . base64_encode(':')]],
166-
'multiple-colons' => [['Basic ' . base64_encode(':::::::')]],
167162
'pile-of-poo-emoji' => [['Basic 💩']],
168163
'only-pile-of-poo-emoji' => [['💩']],
169164
'basic-prefix-without-content' => [['Basic ']],
@@ -182,11 +177,15 @@ public function provideValidAuthentication(): array
182177
return [
183178
'aladdin' => ['Aladdin', 'OpenSesame', ['Basic ' . base64_encode('Aladdin:OpenSesame')]],
184179
'passwords-with-colon' => ['Aladdin', 'Open:Sesame', ['Basic ' . base64_encode('Aladdin:Open:Sesame')]],
180+
'username-without-password' => ['Aladdin', '', ['Basic ' . base64_encode('Aladdin:')]],
181+
'password-without-username' => ['', 'OpenSesame', ['Basic ' . base64_encode(':OpenSesame')]],
185182
'passwords-with-multiple-colons' => [
186183
'Aladdin',
187-
':Open:Sesame:',
188-
['Basic ' . base64_encode('Aladdin::Open:Sesame:')]
184+
'::Open:::Sesame::',
185+
['Basic ' . base64_encode('Aladdin:::Open:::Sesame::')]
189186
],
187+
'no-username-or-password' => ['', '', ['Basic ' . base64_encode(':')]],
188+
'no-username-password-only-colons' => ['', '::::::', ['Basic ' . base64_encode(':::::::')]],
190189
];
191190
}
192191
}

0 commit comments

Comments
 (0)