Skip to content

Commit e7fb981

Browse files
bjrarazeck-ops
authored andcommitted
[awsxrayexporter] Generate url section in xray segment when net.peer.name is available (open-telemetry#36530)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Generate url section in X-Ray segment when net.peer.name is available <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#35375. <!--Describe what testing was performed and which tests were added.--> #### Testing Unit test
1 parent cc51a3a commit e7fb981

File tree

3 files changed

+29
-0
lines changed

3 files changed

+29
-0
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: enhancement
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: awsxrayexporter
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: "Generate url section in xray segment when `net.peer.name` is available"
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [35375]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [user]

exporter/awsxrayexporter/internal/translator/http.go

+1
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ func makeHTTP(span ptrace.Span) (map[string]pcommon.Value, *awsxray.HTTPData) {
9292
hasHTTPRequestURLAttributes = true
9393
case conventions.AttributeNetPeerName:
9494
urlParts[key] = value.Str()
95+
hasHTTPRequestURLAttributes = true
9596
case conventions.AttributeNetPeerPort:
9697
urlParts[key] = value.Str()
9798
if len(urlParts[key]) == 0 {

exporter/awsxrayexporter/internal/translator/http_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ func TestClientSpanWithPeerAttributes(t *testing.T) {
8888

8989
assert.NotNil(t, httpData)
9090
assert.NotNil(t, filtered)
91+
assert.NotNil(t, httpData.Request.URL)
9192

9293
assert.Equal(t, "10.8.17.36", *httpData.Request.ClientIP)
9394

0 commit comments

Comments
 (0)