Added autoconfiguring of enum and added an alias for enum registry

Author: yann-eugone

DependencyInjection/Configuration.php

@@ -24,6 +24,14 @@ public function getConfigTreeBuilder()
                     ->info('[DEPRECATED] bundles for which to auto-register enums.')
                     ->defaultFalse()
                 ->end()
+                ->booleanNode('enum_autoconfiguration')
+                    ->info('If set to true, all services that implements EnumInterface, will obtain the "enum" tag automatically.')
+                    ->defaultTrue()
+                ->end()
+                ->booleanNode('enum_registry_autoconfigurable')
+                    ->info('If set to true, add an alias for the enum registry so your service can ask for it via autoconfiguration.')
+                    ->defaultTrue()
+                ->end()
             ->end()
         ;
 

DependencyInjection/EnumExtension.php

@@ -7,6 +7,7 @@
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 use Yokai\EnumBundle\Enum\EnumInterface;
+use Yokai\EnumBundle\Registry\EnumRegistryInterface;
 
 /**
  * @author Yann Eugoné <[email protected]>
@@ -29,9 +30,13 @@ public function load(array $configs, ContainerBuilder $container)
         $xmlLoader->load('validators.xml');
         $xmlLoader->load('twig.xml');
 
-        if (method_exists($container, 'registerForAutoconfiguration')) {
+        if ($config['enum_autoconfiguration'] && method_exists($container, 'registerForAutoconfiguration')) {
             $container->registerForAutoconfiguration(EnumInterface::class)
                 ->addTag('enum');
         }
+
+        if ($config['enum_registry_autoconfigurable']) {
+            $container->setAlias(EnumRegistryInterface::class, 'enum.registry');
+        }
     }
 }

Tests/DependencyInjection/EnumExtensionTest.php

@@ -0,0 +1,75 @@
+<?php
+
+namespace Yokai\EnumBundle\Tests\DependencyInjection;
+
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Yokai\EnumBundle\DependencyInjection\EnumExtension;
+use Yokai\EnumBundle\Enum\EnumInterface;
+use Yokai\EnumBundle\Registry\EnumRegistryInterface;
+
+/**
+ * @author Yann Eugoné <[email protected]>
+ */
+class EnumExtensionTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @return EnumExtension
+     */
+    public function extension()
+    {
+        return new EnumExtension();
+    }
+
+    /**
+     * @test
+     */
+    public function it_register_enum_for_autoconfiguration_by_default()
+    {
+        $container = new ContainerBuilder();
+        $this->extension()->load([[]], $container);
+
+        if (method_exists($container, 'getAutoconfiguredInstanceof')) {
+            $autoconfigure = $container->getAutoconfiguredInstanceof();
+            $this->assertArrayHasKey(EnumInterface::class, $autoconfigure);
+            $this->assertEquals(['enum' => [[]]], $autoconfigure[EnumInterface::class]->getTags());
+        } else {
+            $this->assertTrue(true); // not in this version
+        }
+    }
+
+    /**
+     * @test
+     */
+    public function it_do_not_register_enum_for_autoconfiguration_if_asked_to()
+    {
+        $container = new ContainerBuilder();
+        $this->extension()->load([['enum_autoconfiguration' => false]], $container);
+
+        if (method_exists($container, 'getAutoconfiguredInstanceof')) {
+            $autoconfigure = $container->getAutoconfiguredInstanceof();
+            $this->assertArrayNotHasKey(EnumInterface::class, $autoconfigure);
+        } else {
+            $this->assertTrue(true); // not in this version
+        }
+    }
+
+    /**
+     * @test
+     */
+    public function it_register_enum_registry_alias_for_autowire_by_default()
+    {
+        $container = new ContainerBuilder();
+        $this->extension()->load([[]], $container);
+        $this->assertTrue($container->hasAlias(EnumRegistryInterface::class));
+    }
+
+    /**
+     * @test
+     */
+    public function it_do_not_register_enum_registry_alias_for_autowire_if_asked_to()
+    {
+        $container = new ContainerBuilder();
+        $this->extension()->load([['enum_registry_autoconfigurable' => false]], $container);
+        $this->assertFalse($container->hasAlias(EnumRegistryInterface::class));
+    }
+}