aeron-io#910 Use a unit test to highlight compilation errors rather than an entry in the build file. Note: this only fails when running with a Java 17 toolchain, not on Java 8 or 11.

Author: tom.johnson

build.gradle

@@ -269,8 +269,7 @@ project(':sbe-tool') {
             'sbe.validation.stop.on.error': 'true',
             'sbe.validation.xsd': validationXsdPath)
         args = ['src/test/resources/json-printer-test-schema.xml',
-                'src/test/resources/composite-elements-schema.xml',
-                'src/test/resources/issue910.xml']
+                'src/test/resources/composite-elements-schema.xml']
     }
 
     jar {

sbe-tool/src/test/java/uk/co/real_logic/sbe/generation/java/QualifiedYieldTest.java

@@ -0,0 +1,59 @@
+package uk.co.real_logic.sbe.generation.java;
+
+import java.util.Map;
+
+import org.agrona.DirectBuffer;
+import org.agrona.MutableDirectBuffer;
+import org.agrona.generation.CompilerUtil;
+import org.agrona.generation.StringWriterOutputManager;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+
+import uk.co.real_logic.sbe.SbeTool;
+import uk.co.real_logic.sbe.Tests;
+import uk.co.real_logic.sbe.ir.Ir;
+import uk.co.real_logic.sbe.xml.IrGenerator;
+import uk.co.real_logic.sbe.xml.MessageSchema;
+import uk.co.real_logic.sbe.xml.ParserOptions;
+
+import static uk.co.real_logic.sbe.xml.XmlSchemaParser.parse;
+
+public class QualifiedYieldTest
+{
+    private static final Class<?> BUFFER_CLASS = MutableDirectBuffer.class;
+    private static final String BUFFER_NAME = BUFFER_CLASS.getName();
+    private static final Class<DirectBuffer> READ_ONLY_BUFFER_CLASS = DirectBuffer.class;
+    private static final String READ_ONLY_BUFFER_NAME = READ_ONLY_BUFFER_CLASS.getName();
+
+    private final StringWriterOutputManager outputManager = new StringWriterOutputManager();
+
+    @Test
+    void shouldGenerateValidJava() throws Exception
+    {
+        System.setProperty(SbeTool.KEYWORD_APPEND_TOKEN, "_");
+
+        final ParserOptions options = ParserOptions.builder().stopOnError(true).build();
+        final MessageSchema schema = parse(Tests.getLocalResource("issue910.xml"), options);
+        final IrGenerator irg = new IrGenerator();
+        final Ir ir = irg.generate(schema);
+        final JavaGenerator generator = new JavaGenerator(
+                ir, BUFFER_NAME, READ_ONLY_BUFFER_NAME, false, false, false, outputManager);
+
+        outputManager.setPackageName(ir.applicableNamespace());
+        generator.generateMessageHeaderStub();
+        generator.generateTypeStubs();
+        generator.generate();
+
+        final Map<String, CharSequence> sources = outputManager.getSources();
+
+        {
+            final String fqClassName = ir.applicableNamespace() + "." + "Issue910FieldDecoder";
+            final Class<?> aClass = CompilerUtil.compileInMemory(fqClassName, sources);
+            assertNotNull(aClass);
+        }
+    }
+}

sbe-tool/src/test/resources/issue910.xml

@@ -34,32 +34,32 @@
         <type name="Array" primitiveType="int32" length="5"/>
         <type name="CharArray" primitiveType="char" length="5"/>
     </types>
-    <sbe:message name="issue910Field" id="1" description="issue 910 field test">
+    <sbe:message name="Issue910Field" id="1" description="issue 910 field test">
         <field name="yield" type="uint64" id="1"/>
     </sbe:message>
-    <sbe:message name="issue910Vardata" id="2" description="issue 910 vardata test">
+    <sbe:message name="Issue910Vardata" id="2" description="issue 910 vardata test">
         <field name="yield" type="varDataEncoding" id="1"/>
     </sbe:message>
-    <sbe:message name="issue910Group" id="3" description="issue 910 group test">
+    <sbe:message name="Issue910Group" id="3" description="issue 910 group test">
         <group name="yield" id="1" dimensionType="groupSizeEncoding">
             <field name="whatever" type="uint64" id="1"/>
         </group>
     </sbe:message>
-    <sbe:message name="issue910GroupField" id="4" description="issue 910 group field test">
+    <sbe:message name="Issue910GroupField" id="4" description="issue 910 group field test">
         <group name="whatever" id="1" dimensionType="groupSizeEncoding">
             <field name="yield" type="uint64" id="1"/>
         </group>
     </sbe:message>
-    <sbe:message name="issue910Enum" id="5" description="issue 910 enum test">
+    <sbe:message name="Issue910Enum" id="5" description="issue 910 enum test">
         <field name="yield" type="Enum" id="1"/>
     </sbe:message>
-    <sbe:message name="issue910Set" id="6" description="issue 910 set test">
+    <sbe:message name="Issue910Set" id="6" description="issue 910 set test">
         <field name="yield" type="Set" id="1"/>
     </sbe:message>
-    <sbe:message name="issue910Array" id="7" description="issue 910 array test">
+    <sbe:message name="Issue910Array" id="7" description="issue 910 array test">
         <field name="yield" type="Array" id="1"/>
     </sbe:message>
-    <sbe:message name="issue910CharArray" id="8" description="issue 910 char array test">
+    <sbe:message name="Issue910CharArray" id="8" description="issue 910 char array test">
         <field name="yield" type="CharArray" id="1"/>
     </sbe:message>
 </sbe:messageSchema>