Merge [email protected]

Author: William Monk

CHANGELOG.md

@@ -1,3 +1,60 @@
+## 1.0.4 (May 22, 2017)
+
+#### :bug: Bug Fix
+
+* `react-error-overlay`
+  * Fix a regression in published package.
+
+### Migrating from 1.0.3 to 1.0.4
+
+Inside any created project that has not been ejected, run:
+
+```
+npm install --save-dev --save-exact [email protected]
+```
+
+or
+
+```
+yarn add --dev --exact [email protected]
+```
+
+## 1.0.3 (May 21, 2017)
+
+#### :bug: Bug Fix
+
+* `react-dev-utils`
+  * [#2297](https://github.com/facebookincubator/create-react-app/pull/2297) Don’t serve the development version from public IPs by default. ([@Timer](https://github.com/Timer))
+
+* `eslint-config-react-app`
+  * [#2311](https://github.com/facebookincubator/create-react-app/pull/2311) Disable `flowtype/require-valid-file-annotation` lint rule due to false positives. ([@Robdel12](https://github.com/Robdel12))
+
+* `react-dev-utils`, `react-error-overlay`
+  * [#2301](https://github.com/facebookincubator/create-react-app/pull/2301) Wrap more `console` calls into a check. ([@BrodaNoel](https://github.com/BrodaNoel))
+
+* `react-scripts`
+  * [#2314](https://github.com/facebookincubator/create-react-app/pull/2314) Fix a "File not found" false positive. ([@gaearon](https://github.com/gaearon))
+
+#### Committers: 4
+- Broda Noel ([BrodaNoel](https://github.com/BrodaNoel))
+- Dan Abramov ([gaearon](https://github.com/gaearon))
+- Joe Haddad ([Timer](https://github.com/Timer))
+- Robert DeLuca ([Robdel12](https://github.com/Robdel12))
+
+### Migrating from 1.0.2 to 1.0.3
+
+Inside any created project that has not been ejected, run:
+
+```
+npm install --save-dev --save-exact [email protected]
+```
+
+or
+
+```
+yarn add --dev --exact [email protected]
+```
+
 ## 1.0.2 (May 20, 2017)
 
 #### :bug: Bug Fix

packages/eslint-config-react-app/index.js

@@ -282,7 +282,8 @@ module.exports = {
 
     // https://github.com/gajus/eslint-plugin-flowtype
     'flowtype/define-flow-type': 'warn',
-    'flowtype/require-valid-file-annotation': 'warn',
+    // TODO: Reenable once https://github.com/gajus/eslint-plugin-flowtype/issues/165 is fixed
+    //'flowtype/require-valid-file-annotation': 'warn',
     'flowtype/use-flow-type': 'warn',
   },
 };

packages/eslint-config-react-app/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-react-app",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "ESLint configuration used by Create React App",
   "repository": "facebookincubator/create-react-app",
   "license": "BSD-3-Clause",

packages/react-dev-utils/WebpackDevServerUtils.js

@@ -52,9 +52,22 @@ function prepareUrls(protocol, host, port) {
   if (isUnspecifiedHost) {
     prettyHost = 'localhost';
     try {
+      // This can only return an IPv4 address
       lanUrlForConfig = address.ip();
       if (lanUrlForConfig) {
-        lanUrlForTerminal = prettyPrintUrl(lanUrlForConfig);
+        // Check if the address is a private ip
+        // https://en.wikipedia.org/wiki/Private_network#Private_IPv4_address_spaces
+        if (
+          /^10[.]|^172[.](1[6-9]|2[0-9]|3[0-1])[.]|^192[.]168[.]/.test(
+            lanUrlForConfig
+          )
+        ) {
+          // Address is private, format it for later use
+          lanUrlForTerminal = prettyPrintUrl(lanUrlForConfig);
+        } else {
+          // Address is not private, so we will discard it
+          lanUrlForConfig = undefined;
+        }
       }
     } catch (_e) {
       // ignored

packages/react-dev-utils/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-dev-utils",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Webpack utilities used by Create React App",
   "repository": "facebookincubator/create-react-app",
   "license": "BSD-3-Clause",

packages/react-dev-utils/webpackHotDevClient.js

@@ -172,7 +172,7 @@ var connection = new SockJS(
 // to avoid spamming the console. Disconnect usually happens
 // when developer stops the server.
 connection.onclose = function() {
-  if (typeof console !== 'undefined') {
+  if (typeof console !== 'undefined' && typeof console.info === 'function') {
     console.info(
       'The development server has disconnected.\nRefresh the page if necessary.'
     );
@@ -186,8 +186,8 @@ var hasCompileErrors = false;
 
 function clearOutdatedErrors() {
   // Clean up outdated compile errors, if any.
-  if (typeof console !== 'undefined') {
-    if (hasCompileErrors && typeof console.clear === 'function') {
+  if (typeof console !== 'undefined' && typeof console.clear === 'function') {
+    if (hasCompileErrors) {
       console.clear();
     }
   }
@@ -226,7 +226,7 @@ function handleWarnings(warnings) {
       errors: [],
     });
 
-    if (typeof console !== 'undefined') {
+    if (typeof console !== 'undefined' && typeof console.warn === 'function') {
       for (var i = 0; i < formatted.warnings.length; i++) {
         console.warn(stripAnsi(formatted.warnings[i]));
       }
@@ -266,7 +266,7 @@ function handleErrors(errors) {
   showErrorOverlay(formatted.errors[0]);
 
   // Also log them to the console.
-  if (typeof console !== 'undefined') {
+  if (typeof console !== 'undefined' && typeof console.error === 'function') {
     for (var i = 0; i < formatted.errors.length; i++) {
       console.error(stripAnsi(formatted.errors[i]));
     }

packages/react-error-overlay/package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-error-overlay",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "An overlay for displaying stack frames.",
   "main": "lib/index.js",
   "scripts": {
@@ -34,7 +34,7 @@
     "anser": "1.2.5",
     "babel-code-frame": "6.22.0",
     "babel-runtime": "6.23.0",
-    "react-dev-utils": "^1.0.2",
+    "react-dev-utils": "^1.0.3",
     "settle-promise": "1.0.0",
     "source-map": "0.5.6"
   },
@@ -44,7 +44,7 @@
     "babel-preset-react-app": "^3.0.0",
     "cross-env": "5.0.0",
     "eslint": "3.19.0",
-    "eslint-config-react-app": "^1.0.1",
+    "eslint-config-react-app": "^1.0.2",
     "eslint-plugin-flowtype": "2.33.0",
     "eslint-plugin-import": "2.2.0",
     "eslint-plugin-jsx-a11y": "5.0.1",

packages/react-error-overlay/src/effects/proxyConsole.js

@@ -50,20 +50,22 @@ const permanentRegister = function proxyConsole(
 ) {
   if (typeof console !== 'undefined') {
     const orig = console[type];
-    console[type] = function __stack_frame_overlay_proxy_console__() {
-      try {
-        const message = arguments[0];
-        if (typeof message === 'string' && reactFrameStack.length > 0) {
-          callback(message, reactFrameStack[reactFrameStack.length - 1]);
+    if (typeof orig === 'function') {
+      console[type] = function __stack_frame_overlay_proxy_console__() {
+        try {
+          const message = arguments[0];
+          if (typeof message === 'string' && reactFrameStack.length > 0) {
+            callback(message, reactFrameStack[reactFrameStack.length - 1]);
+          }
+        } catch (err) {
+          // Warnings must never crash. Rethrow with a clean stack.
+          setTimeout(function() {
+            throw err;
+          });
         }
-      } catch (err) {
-        // Warnings must never crash. Rethrow with a clean stack.
-        setTimeout(function() {
-          throw err;
-        });
-      }
-      return orig.apply(this, arguments);
-    };
+        return orig.apply(this, arguments);
+      };
+    }
   }
 };
 

tasks/release.sh

@@ -40,5 +40,9 @@ if [ -n "$(git status --porcelain)" ]; then
 fi
 
 cd "$root_path"
+# Compile
+cd packages/react-error-overlay/
+npm run build:prod
+cd ../..
 # Go!
 ./node_modules/.bin/lerna publish --independent "$@"