-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Host webpack/media logo's on webpack.js.org #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yea I can take this up this weekend, already had the update for the logo component in mind after seeing @jhnns comment a while ago, just hadn't gotten around to it. For this issue, basically we just want a webpack branding page where people can just go download the logo and icon files for easy inclusion anywhere, correct? If so, assign this to me and I'll pick it up this weekend. |
Very nice :). Yeah a webpack branding page would be even better, initially I meant purely hosting the files, but a page dedicated to it is much better. https://github.com/webpack/media currently also serves as a branding page, so you might use that.
Are you talking about updating the logo + text to be a SVG? That would be nice. Let me know, I can help you test if it looks good on some devices. |
Ah good point, yea maybe I'll just link there to start. I need shift things around in the Navigation component as it's starting to get a bit cluttered with the current layout. At the very least I can add a link to the media repo there or in Footer.
Exactly, I think @jhnns mentioned he'd prefer that as opposed to using geomanist directly.
Sounds good 👍 |
Adding |
@bebraw that's a good idea, I was thinking maybe via a submodule but maybe sticking with npm for everything is simpler. Maybe we should create another issue to start discussing how we can break parts of this repo out (as we were discussing with the components) and consume other repos like I'm also interested in what the team's plans are for the analyze tool. Ideally maybe we could have shared repo of components and utilities that this site, the analyze tool, and others all consume for a consistent interface? |
Or maybe things like the voting app and analyze tool can be separate SPAs that this site consumes and displays under one of it's routes? |
Seems like a good idea. If we go that way, it'll probably take a while before the webpack logo's are hosted. Is it possible to temporarily upload the logo's somewhere on the site meanwhile? @michael-ciniawsky needs this for a huge refactoring of README's from webpack repo's. |
@SpaceK33z yea should've just created a new issue... done at #301.
Definitely. Still planning to address this today or tomorrow. I'll be opening a PR soon. |
ping :) |
#303 fixed this issue and was merged so I'm closing. @michael-ciniawsky there's a branding link in the footer which will bring you to a page to download the logos or icon although we still may need to do a deployment before it's actually live. |
Maybe not right here, but is it not possible to host it by simply enable gh-pages in webpack/media? Sure I can download it, but then each loader repo still must enable gh-pages to serve it. |
sry I misunderstood 'to download' 😛 , thought there is a download link only but got the url |
@michael-ciniawsky haha no problem. Yea we could definitely create a gh-pages branch to host the branding guidelines page from the media repository or |
The webpack logo's should be available somewhere on a hosted place. This way we can use the logo in README's etc.
It looks like the path to the logo at the top-left of the website is a hash, so this is too tricky. Also it should be a SVG version.
We need this feature in relatively short-term for the new loader README's (webpack/webpack/issues/3195).
@skipjack, do you happen to know an easy way to do this?
The text was updated successfully, but these errors were encountered: