Skip to content

Build time is insufferably long #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Munter opened this issue Apr 10, 2018 · 16 comments · Fixed by #2039
Closed

Build time is insufferably long #2018

Munter opened this issue Apr 10, 2018 · 16 comments · Fixed by #2039

Comments

@Munter
Copy link
Collaborator

Munter commented Apr 10, 2018

This is my laptop building the documentation site:

image

This total resource consumption has been going on for around 20 minutes now.

Further more I see the build times tripling in travis:

image

It looks like b45b73e introduced a major performance regression

@montogeek
Copy link
Member

Build times have been always big, that's one of the reasons we are rebuilding it on rebuild branch.

@montogeek
Copy link
Member

This regression is bad, now it takes 8 mins to build it on my Mac, it used to take up to 3 mins :/
@EugeneHlushko @bebraw Any idea what could be causing this?

@EugeneHlushko
Copy link
Member

Will profile this in evening asap

@bebraw
Copy link
Contributor

bebraw commented Apr 11, 2018

@montogeek I sped up Antwar considerably a while ago (webpack 4 upgrade and other tuning). I don't know which version or setup your are using, though.

@montogeek
Copy link
Member

montogeek commented Apr 11, 2018

@bebraw
Copy link
Contributor

bebraw commented Apr 11, 2018

@montogeek Ok, hard to say without profiling. There are some optimizations I could do but I don't have time.

@EugeneHlushko
Copy link
Member

BTW it did not look worse than original locally when i tested it initially, didn't expect to grow the build time with this PR. Maybe there is an extra iteration going on? 17min => 35 min looks very very bad

@EugeneHlushko
Copy link
Member

the 44 min was probably due to change of packages cached vs not cached somewhere under .../.npm/cache/ next builds are very close 2x vs 3x of first build with updated packages and wp4

@EugeneHlushko
Copy link
Member

EugeneHlushko commented Apr 11, 2018

Can we set node to ^8.9.0 here ? https://travis-ci.org/webpack/webpack.js.org/jobs/364985003/config
cc @jeremenichelli @montogeek @skipjack

Most of the optimizations we did back at next branch in webpack repo were measured on node 8++ so i suspect we should bump the node ver on integrations too

@jeremenichelli
Copy link
Member

I was about to mention the Node version. We can check locally first if everything works as expected from a fresh install, and it everything looks good, then change it.

@EugeneHlushko
Copy link
Member

i cannot check until tonight, if anyone willing to give it a shot before that pls do

@montogeek
Copy link
Member

I have Node 8.10, still takes 8 minutes

@skipjack
Copy link
Collaborator

@EugeneHlushko @montogeek @jeremenichelli I'm fine with whatever you all want to use in terms of the latest node engine. On rebuild, I'm using the latest stable version of node and the pure webpack build using the SSGPlugin amounts to ~30s (and there's probably more opportunities for optimizations).

At this point, rebuild is getting much closer as @montogeek has helped to tackle a few of the remaining things. I updated react-banner yesterday (an abstraction of our Navigation component) which means I can finish the much simpler Navigation component on that branch. I'm going to spend some time on that this saturday and, if I have any remaining time, try to tackle another item from the list of TODOs.

Sorry if I'm sidetracking this conversation, but I just thought it's worth mentioning that we might be a week or two away from merging rebuild (especially if others keep helping). Maybe I'll open a PR soon if it hasn't been done already.

@EugeneHlushko
Copy link
Member

I am looking at TODO list now and may help with things. Would be nice to get invite to slack @skipjack we had pinged Sean with @montogeek multiple times but he seems to ignore those notifications :D

@skipjack
Copy link
Collaborator

@EugeneHlushko actually I can invite you to slack myself, feel free to share your email here, send it to me privately on gitter or send me an email (use the one on my profile).

@skipjack skipjack mentioned this issue Apr 15, 2018
16 tasks
@Munter
Copy link
Collaborator Author

Munter commented Aug 6, 2018

This is fixed on the rebuild branch

@Munter Munter closed this as completed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants