-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Build time is insufferably long #2018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Build times have been always big, that's one of the reasons we are rebuilding it on |
This regression is bad, now it takes 8 mins to build it on my Mac, it used to take up to 3 mins :/ |
Will profile this in evening asap |
@montogeek I sped up Antwar considerably a while ago (webpack 4 upgrade and other tuning). I don't know which version or setup your are using, though. |
@bebraw 0.28.3 https://github.com/webpack/webpack.js.org/blob/master/package.json#L44, that is the last one. |
@montogeek Ok, hard to say without profiling. There are some optimizations I could do but I don't have time. |
BTW it did not look worse than original locally when i tested it initially, didn't expect to grow the build time with this PR. Maybe there is an extra iteration going on? 17min => 35 min looks very very bad |
the 44 min was probably due to change of packages cached vs not cached somewhere under .../.npm/cache/ next builds are very close 2x vs 3x of first build with updated packages and wp4 |
Can we set node to ^8.9.0 here ? https://travis-ci.org/webpack/webpack.js.org/jobs/364985003/config Most of the optimizations we did back at |
I was about to mention the Node version. We can check locally first if everything works as expected from a fresh install, and it everything looks good, then change it. |
i cannot check until tonight, if anyone willing to give it a shot before that pls do |
I have Node 8.10, still takes 8 minutes |
@EugeneHlushko @montogeek @jeremenichelli I'm fine with whatever you all want to use in terms of the latest node engine. On At this point, Sorry if I'm sidetracking this conversation, but I just thought it's worth mentioning that we might be a week or two away from merging |
I am looking at TODO list now and may help with things. Would be nice to get invite to slack @skipjack we had pinged Sean with @montogeek multiple times but he seems to ignore those notifications :D |
@EugeneHlushko actually I can invite you to slack myself, feel free to share your email here, send it to me privately on gitter or send me an email (use the one on my profile). |
This is fixed on the |
This is my laptop building the documentation site:
This total resource consumption has been going on for around 20 minutes now.
Further more I see the build times tripling in travis:
It looks like b45b73e introduced a major performance regression
The text was updated successfully, but these errors were encountered: