Skip to content

Commit c1b3e7c

Browse files
committed
chore: update
1 parent 58ceb75 commit c1b3e7c

File tree

7 files changed

+13
-24
lines changed

7 files changed

+13
-24
lines changed

packages/reactivity/__tests__/baseWatch.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
baseWatch,
77
onEffectCleanup,
88
ref,
9-
} from '../src/index'
9+
} from '../src'
1010

1111
const queue: SchedulerJob[] = []
1212

packages/reactivity/src/baseWatch.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,12 @@ export interface SchedulerJob extends Function {
5858
}
5959

6060
type WatchEffect = (onCleanup: OnCleanup) => void
61-
6261
type WatchSource<T = any> = Ref<T> | ComputedRef<T> | (() => T)
63-
6462
type WatchCallback<V = any, OV = any> = (
6563
value: V,
6664
oldValue: OV,
6765
onCleanup: OnCleanup,
6866
) => any
69-
7067
type OnCleanup = (cleanupFn: () => void) => void
7168

7269
export interface BaseWatchOptions<Immediate = boolean> extends DebuggerOptions {
@@ -86,17 +83,14 @@ export type Scheduler = (
8683
effect: ReactiveEffect,
8784
isInit: boolean,
8885
) => void
89-
90-
const DEFAULT_SCHEDULER: Scheduler = job => job()
91-
9286
export type HandleError = (err: unknown, type: BaseWatchErrorCodes) => void
87+
export type HandleWarn = (msg: string, ...args: any[]) => void
9388

89+
const DEFAULT_SCHEDULER: Scheduler = job => job()
9490
const DEFAULT_HANDLE_ERROR: HandleError = (err: unknown) => {
9591
throw err
9692
}
9793

98-
export type HandleWarn = (msg: string, ...args: any[]) => void
99-
10094
const cleanupMap: WeakMap<ReactiveEffect, (() => void)[]> = new WeakMap()
10195
let activeEffect: ReactiveEffect | undefined = undefined
10296

packages/reactivity/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ export { TrackOpTypes, TriggerOpTypes, ReactiveFlags } from './constants'
7272
export {
7373
baseWatch,
7474
onEffectCleanup,
75-
BaseWatchErrorCodes,
7675
traverse,
76+
BaseWatchErrorCodes,
7777
type BaseWatchOptions,
7878
type Scheduler,
7979
} from './baseWatch'

packages/runtime-core/src/apiWatch.ts

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
getCurrentScope,
99
} from '@vue/reactivity'
1010
import {
11-
type CreateScheduler,
11+
type SchedulerFactory,
1212
createPreScheduler,
1313
createSyncScheduler,
1414
} from './scheduler'
@@ -156,9 +156,7 @@ export function watch<T = any, Immediate extends Readonly<boolean> = false>(
156156
return doWatch(source as any, cb, options)
157157
}
158158

159-
function getSchedulerByFlushMode(
160-
flush: WatchOptionsBase['flush'],
161-
): CreateScheduler {
159+
function getScheduler(flush: WatchOptionsBase['flush']): SchedulerFactory {
162160
if (flush === 'post') {
163161
return createPostRenderScheduler
164162
}
@@ -224,12 +222,9 @@ function doWatch(
224222
}
225223

226224
const instance = currentInstance
227-
228225
extendOptions.onError = (err: unknown, type: BaseWatchErrorCodes) =>
229226
handleErrorWithInstance(err, instance, type)
230-
231-
const scheduler = getSchedulerByFlushMode(flush)(instance)
232-
extendOptions.scheduler = scheduler
227+
extendOptions.scheduler = getScheduler(flush)(instance)
233228

234229
let effect = baseWatch(source, cb, extend({}, options, extendOptions))
235230

packages/runtime-core/src/componentOptions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -942,7 +942,7 @@ export function createWatcher(
942942
? createPathGetter(publicThis, key)
943943
: () => (publicThis as any)[key]
944944

945-
const options: WatchOptions<false> = {}
945+
const options: WatchOptions = {}
946946
if (__COMPAT__) {
947947
const instance =
948948
getCurrentScope() === currentInstance?.scope ? currentInstance : null

packages/runtime-core/src/renderer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ import {
3838
isReservedProp,
3939
} from '@vue/shared'
4040
import {
41-
type CreateScheduler,
41+
type SchedulerFactory,
4242
type SchedulerJob,
4343
flushPostFlushCbs,
4444
flushPreFlushCbs,
@@ -282,7 +282,7 @@ export const queuePostRenderEffect = __FEATURE_SUSPENSE__
282282
: queueEffectWithSuspense
283283
: queuePostFlushCb
284284

285-
export const createPostRenderScheduler: CreateScheduler =
285+
export const createPostRenderScheduler: SchedulerFactory =
286286
instance => (job, effect, isInit) => {
287287
if (isInit) {
288288
queuePostRenderEffect(

packages/runtime-core/src/scheduler.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -289,11 +289,11 @@ function checkRecursiveUpdates(seen: CountMap, fn: SchedulerJob) {
289289
}
290290
}
291291

292-
export type CreateScheduler = (
292+
export type SchedulerFactory = (
293293
instance: ComponentInternalInstance | null,
294294
) => Scheduler
295295

296-
export const createSyncScheduler: CreateScheduler =
296+
export const createSyncScheduler: SchedulerFactory =
297297
instance => (job, effect, isInit) => {
298298
if (isInit) {
299299
effect.run()
@@ -302,7 +302,7 @@ export const createSyncScheduler: CreateScheduler =
302302
}
303303
}
304304

305-
export const createPreScheduler: CreateScheduler =
305+
export const createPreScheduler: SchedulerFactory =
306306
instance => (job, effect, isInit) => {
307307
if (isInit) {
308308
effect.run()

0 commit comments

Comments
 (0)