Skip to content

[Regression] ReferenceError: Can't find variable: Reflect #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
haoqunjiang opened this issue Oct 15, 2018 · 1 comment · Fixed by #284
Closed

[Regression] ReferenceError: Can't find variable: Reflect #283

haoqunjiang opened this issue Oct 15, 2018 · 1 comment · Fixed by #284

Comments

@haoqunjiang
Copy link
Member

See vuejs/vue-cli#2733 for reproduction.
This regression is introduced in d570fa3#diff-5bb099174f678e4d728de8e607013b3aR5

The correct way to detect Reflect support should be:

return typeof Reflect !== 'undefined' && Reflect.defineMetadata
This was referenced Oct 15, 2018
Closed
Closed
@ktsn ktsn mentioned this issue Oct 15, 2018
Merged
@ktsn ktsn closed this as completed in #284 Oct 15, 2018
@ktsn
Copy link
Member

ktsn commented Oct 15, 2018 •
edited
Loading

Thanks! Fixed via v6.3.1 v6.3.2.

@haoqunjiang haoqunjiang mentioned this issue Oct 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix checking Reflect existance vuejs/vue-class-component
2 participants
@ktsn @haoqunjiang