Skip to content

fix: allow to reconfigure proxied properties in data hook #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2017

Conversation

ktsn
Copy link
Member

@ktsn ktsn commented Nov 3, 2017

Currently, Babel decorators cannot define props and methods because it tries to reconfigure proxied properties, then Cannot redefine property error is thrown.

This fix allows the users to create property decorators that declare props/methods in Babel.

This does not solve the difference between babel and ts decorator behaviors but I think it does not matter that users make their own custom decorator with caution.

This fix allows the users to create property decorators
that declare props/methods in Babel.
@ktsn ktsn merged commit e9f0e6b into master Nov 3, 2017
@ktsn ktsn deleted the fix-proxy-descriptors branch November 3, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant