Language attribute of <html> element should not be set to English by default #599
Labels
bug
Something isn't working
Comments
|
Hi @botic Sure, feel free to open a PR to fix this 👍 |
Sorry, now included. The Nightwatch template should be irrelevant, so it's just the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current HTML template explictly sets the language attribute to English with
lang="en". This turned out to be a bad pattern if your project is not solely targeting the English-speaking communities. Google Chrome might auto-translate such pages, even if the actual language of the text is in German.See more details here: vuejs/vue-cli#5945
If not changed, Vite-powered Vue projects will see a high number of false language attributes in the wild!
Code search returned two places with explicit language attribute:
Expected behavior
The language attribute on the element of the template should be absent or empty. This will let the user agent decide (e.g. autodetect) the language of the page.
You can find the vue-cli solution here: vuejs/vue-cli@2373df1
How to reproduce
Just create a new project :-)
The text was updated successfully, but these errors were encountered: