♻️ Remove hacky/illegal Number conversion

vhoyer · vhoyer · commit 2f327e6e89ca · 2022-01-24T22:11:04.000-03:00
Also typescript doesn't recognize this technique
diff --git a/src/rules/tabindex-no-positive.ts b/src/rules/tabindex-no-positive.ts
@@ -22,7 +22,7 @@ const rule: Rule.RuleModule = {
       VElement(node) {
         const tabIndex = getLiteralAttributeValue(node, "tabindex");
 
-        if (tabIndex && +tabIndex > 0) {
+        if (tabIndex && Number(tabIndex) > 0) {
           context.report({ node: node as any, messageId: "default" });
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ const rule: Rule.RuleModule = {`
`22`	`22`	`VElement(node) {`
`23`	`23`	`const tabIndex = getLiteralAttributeValue(node, "tabindex");`
`24`	`24`
`25`		`- if (tabIndex && +tabIndex > 0) {`
	`25`	`+ if (tabIndex && Number(tabIndex) > 0) {`
`26`	`26`	`context.report({ node: node as any, messageId: "default" });`
`27`	`27`	`}`
`28`	`28`	`}`