Skip to content
This repository was archived by the owner on May 19, 2021. It is now read-only.

Some typing errors in strings (Form1.cs) #48

Closed
hexenwerkgames opened this issue Mar 26, 2018 · 5 comments
Closed

Some typing errors in strings (Form1.cs) #48

hexenwerkgames opened this issue Mar 26, 2018 · 5 comments

Comments

@hexenwerkgames
Copy link
Contributor

hexenwerkgames commented Mar 26, 2018

I've found some typing errors in strings in Form1.cs

I'm not so familiar with github yet, but I started a pull request and hope this works. :)

@unitycoder
Copy link
Owner

for some reason it shows the whole file as changed (every line).. so i'm not sure what was changed..

looks like this issue,
https://stackoverflow.com/questions/19593909/git-diff-sees-whole-file-as-changed-when-its-not

are you using commandline git, or sourcetree, github desktop?

@hexenwerkgames
Copy link
Contributor Author

Oh, I see ... my fault, I just uploaded the single file manually via browser. I guess that (maybe) only works for new files. I closed the pull request and I will see if it helps to use one of the tools you mentioned.

@hexenwerkgames
Copy link
Contributor Author

Looks like the second try worked. What I haven't found in the files were e.g. the names of the tabs.
Maybe you'd like to change "Unity's" to "Unitys" or "Unity Versions"
and in Settings: "Explorer context menu: Install / Uninstall" (consistency)
and "Check for Updates" ?

Yeah ... nitpicking by a non-coder. :)

@unitycoder
Copy link
Owner

unitycoder commented Mar 28, 2018

ok, looks fine now thanks! (ill merge it sometime this week and check those titles)

@unitycoder
Copy link
Owner

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants