fix randomization issue

Author: unitycoder

MainWindow.xaml.cs

@@ -29,7 +29,7 @@ namespace PointCloudConverter
 {
     public partial class MainWindow : Window
     {
-        static readonly string version = "29.03.2025";
+        static readonly string version = "02.04.2025";
         static readonly string appname = "PointCloud Converter - " + version;
         static readonly string rootFolder = AppDomain.CurrentDomain.BaseDirectory;
 

Tools/Tools.cs

@@ -1,5 +1,6 @@
 using PointCloudConverter.Structs;
 using SharpNeatLib.Maths;
+using System.Collections;
 using System.Globalization;
 using System.IO;
 using System.Numerics;
@@ -139,6 +140,32 @@ public static Vector2 SuperUnpacker(float f, float GridSizeAndPackMagic)
         //    return (ax * bx + ay * by + az * bz);
         //}
 
+        public static void ShuffleInPlace(params IList[] arrays)
+        {
+            //ResetRandom();
+
+            // Assume all lists are the same length
+            if (arrays.Length == 0 || arrays[0] == null)
+                return;
+
+            int count = arrays[0].Count;
+
+            for (int i = count - 1; i > 0; i--)
+            {
+                int rand = frnd.Next(0, i + 1);
+
+                foreach (var list in arrays)
+                {
+                    if (list == null || list.Count <= i || list.Count <= rand)
+                        continue;
+
+                    object temp = list[i];
+                    list[i] = list[rand];
+                    list[rand] = temp;
+                }
+            }
+        }
+
 
         public static void Shuffle(ref List<float> array)
         {
@@ -149,8 +176,8 @@ public static void Shuffle(ref List<float> array)
                 int rand = frnd.Next(0, index--);
                 (array[index], array[rand]) = (array[rand], array[index]);
             }
-        }        
-        
+        }
+
         public static void Shuffle(ref List<byte> array)
         {
             ResetRandom();

Writers/PCROOT.cs

@@ -2,6 +2,7 @@
 
 using PointCloudConverter.Logger;
 using System;
+using System.Collections;
 using System.Diagnostics;
 using System.IO;
 using System.Runtime.CompilerServices;
@@ -537,71 +538,26 @@ void IWriter.Save(int fileIndex)
                 // randomize points in this node
                 if (importSettings.randomize)
                 {
-                    //ShuffleFlags flags = ShuffleFlags.None;
-                    //int rand = Tools.frnd.Next(0, index--);
+                    var listsToShuffle = new List<IList> { nodeTempX, nodeTempY, nodeTempZ };
 
-                    Tools.Shuffle(ref nodeTempX);
-                    Tools.Shuffle(ref nodeTempY);
-                    Tools.Shuffle(ref nodeTempZ);
-
-                    // NOTE now we shuffle all arrays, even if not all are used?
-                    if (importSettings.importRGB == true || (importSettings.importIntensity == true || importSettings.importClassification == true))
+                    if (importSettings.importRGB)
                     {
-                        Tools.Shuffle(ref nodeTempR);
-                        Tools.Shuffle(ref nodeTempG);
-                        Tools.Shuffle(ref nodeTempB);
+                        listsToShuffle.Add(nodeTempR);
+                        listsToShuffle.Add(nodeTempG);
+                        listsToShuffle.Add(nodeTempB);
                     }
 
-                    if (importSettings.importIntensity == true) Tools.Shuffle(ref nodeTempIntensity);
-                    if (importSettings.importClassification == true) Tools.Shuffle(ref nodeTempClassification);
+                    if (importSettings.importIntensity)
+                        listsToShuffle.Add(nodeTempIntensity);
 
-                    //if (importSettings.importRGB == true)
-                    //{
-                    //    if (importSettings.packColors == true)
-                    //    {
-
-                    //    }
-                    //    else // not packed
-                    //    {
-                    //        //// intensity or classification are saved into rgb field if not packed
-                    //        //if (importSettings.importIntensity || importSettings.importClassification)
-                    //        //{
-                    //        //    Tools.Shuffle(ref nodeTempR);
-                    //        //    Tools.Shuffle(ref nodeTempG);
-                    //        //    Tools.Shuffle(ref nodeTempB);
-                    //        //}
-
-                    //        // if separate intensity
-                    //        if (importSettings.importIntensity)
-                    //        {
-                    //            Tools.Shuffle(ref nodeTempIntensity);
-                    //        }
-
-                    //        // if separate classification
-                    //        if (importSettings.importClassification)
-                    //        {
-                    //            Tools.Shuffle(ref nodeTempClassification);
-                    //        }
-                    //    }
-                    //}
-                    //else // no rgb
-                    //{
-                    //    if (importSettings.importIntensity)
-                    //    {
-                    //        Tools.Shuffle(ref nodeTempIntensity);
-                    //    }
-
-                    //    // if separate classification
-                    //    if (importSettings.importClassification)
-                    //    {
-                    //        Tools.Shuffle(ref nodeTempClassification);
-                    //    }
-                    //}
+                    if (importSettings.importClassification)
+                        listsToShuffle.Add(nodeTempClassification);
 
                     if (importSettings.averageTimestamp)
-                    {
-                        Tools.Shuffle(ref nodeTempTime);
-                    }
+                        listsToShuffle.Add(nodeTempTime);
+
+                    Tools.ShuffleInPlace(listsToShuffle.ToArray());
+
                 }