From 2c233890c1ac6f588c895281e13659ada5865f32 Mon Sep 17 00:00:00 2001 From: rylempka Date: Mon, 13 May 2024 19:24:29 -0700 Subject: [PATCH] Replace subprocess.Popen with subprocess.run to prevent Docker container exit when launching containers in detached mode --- scripts/launch_triton_server.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/launch_triton_server.py b/scripts/launch_triton_server.py index e0dcc2ef..bdd6d7cb 100644 --- a/scripts/launch_triton_server.py +++ b/scripts/launch_triton_server.py @@ -111,4 +111,4 @@ def get_cmd(world_size, tritonserver, grpc_port, http_port, metrics_port, if args.multi_model: assert args.world_size == 1, 'World size must be 1 when using multi-model. Processes will be spawned automatically to run the multi-GPU models' env['TRTLLM_ORCHESTRATOR'] = '1' - subprocess.Popen(cmd, env=env) + subprocess.run(cmd, env=env, check=True)