Skip to content

Commit cab900c

Browse files
authored
fix(sdk): do not initialize logger if not instructed (#156)
1 parent 0225fcd commit cab900c

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

packages/traceloop-sdk/src/lib/configuration/index.ts

+8-9
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,13 @@ export const initialize = (options: InitializeOptions) => {
6060

6161
_configuration = Object.freeze(options);
6262

63-
diag.setLogger(
64-
new DiagConsoleLogger(),
65-
logLevelToOtelLogLevel(options.logLevel),
66-
);
67-
68-
diag.info(
63+
if (options.logLevel) {
64+
diag.setLogger(
65+
new DiagConsoleLogger(),
66+
logLevelToOtelLogLevel(options.logLevel),
67+
);
68+
}
69+
console.log(
6970
`Traceloop exporting traces to ${
7071
_configuration.exporter ? "a custom exporter" : _configuration.baseUrl
7172
}`,
@@ -76,7 +77,7 @@ export const initialize = (options: InitializeOptions) => {
7677
};
7778

7879
const logLevelToOtelLogLevel = (
79-
logLevel?: "debug" | "info" | "warn" | "error",
80+
logLevel: "debug" | "info" | "warn" | "error",
8081
) => {
8182
switch (logLevel) {
8283
case "debug":
@@ -87,7 +88,5 @@ const logLevelToOtelLogLevel = (
8788
return DiagLogLevel.WARN;
8889
case "error":
8990
return DiagLogLevel.ERROR;
90-
default:
91-
return DiagLogLevel.INFO;
9291
}
9392
};

packages/traceloop-sdk/src/lib/interfaces/initialize-options.interface.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export interface InitializeOptions {
3030

3131
/**
3232
* Defines default log level for SDK and all instrumentations. Optional.
33-
* Defaults to info.
33+
* Defaults to error.
3434
*/
3535
logLevel?: "debug" | "info" | "warn" | "error";
3636

0 commit comments

Comments
 (0)