From 65969f5caaf0af9f7f5328cc56bcc2f03e13fefc Mon Sep 17 00:00:00 2001 From: Shane Krueger Date: Sat, 6 Nov 2021 21:50:42 -0400 Subject: [PATCH 1/4] Fix filename in readme file --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9c043b3..3ecaf2b 100644 --- a/README.md +++ b/README.md @@ -135,7 +135,7 @@ On the page of your newly created or existing GitHub repo, click **Settings** -> The default configuration of this example package **assumes you publish package with an unscoped name to npm**. GitHub Packages must be named with a scope name such as "@tomchen/example-typescript-package". -Change `scope: '@tomchen'` to your own scope in **.github/workflows/test.yml**, also change `addscope` in **package.json**. +Change `scope: '@tomchen'` to your own scope in **.github/workflows/publish.yml**, also change `addscope` in **package.json**. If you publish package with a scoped name to npm, change the name to something like "@tomchen/example-typescript-package" in **package.json**, and remove the `- run: npm run addscope` line in **.github/workflows/test.yml** From 4f042a74a9f85389dc62d053e05eea5af6cf239c Mon Sep 17 00:00:00 2001 From: Shane Krueger Date: Sat, 6 Nov 2021 21:52:16 -0400 Subject: [PATCH 2/4] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3ecaf2b..3facb0b 100644 --- a/README.md +++ b/README.md @@ -137,7 +137,7 @@ The default configuration of this example package **assumes you publish package Change `scope: '@tomchen'` to your own scope in **.github/workflows/publish.yml**, also change `addscope` in **package.json**. -If you publish package with a scoped name to npm, change the name to something like "@tomchen/example-typescript-package" in **package.json**, and remove the `- run: npm run addscope` line in **.github/workflows/test.yml** +If you publish package with a scoped name to npm, change the name to something like "@tomchen/example-typescript-package" in **package.json**, and remove the `- run: npm run addscope` line in **.github/workflows/publish.yml** If you publish your package to npm only, and don't want to publish to GitHub Packages, then delete the lines from `- name: Setup .npmrc file to publish to GitHub Packages` to the end of the file in **.github/workflows/test.yml**. From 801cf580bba55b02b1ccbc98ff1be1386de2966a Mon Sep 17 00:00:00 2001 From: Shane Krueger Date: Sat, 6 Nov 2021 21:53:27 -0400 Subject: [PATCH 3/4] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3facb0b..6c4da95 100644 --- a/README.md +++ b/README.md @@ -139,7 +139,7 @@ Change `scope: '@tomchen'` to your own scope in **.github/workflows/publish.yml* If you publish package with a scoped name to npm, change the name to something like "@tomchen/example-typescript-package" in **package.json**, and remove the `- run: npm run addscope` line in **.github/workflows/publish.yml** -If you publish your package to npm only, and don't want to publish to GitHub Packages, then delete the lines from `- name: Setup .npmrc file to publish to GitHub Packages` to the end of the file in **.github/workflows/test.yml**. +If you publish your package to npm only, and don't want to publish to GitHub Packages, then delete the lines from `- name: Setup .npmrc file to publish to GitHub Packages` to the end of the file in **.github/workflows/publish.yml**. (You might have noticed `secret.GITHUB_TOKEN` in **.github/workflows/test.yml**. You don't need to set up a secret named `GITHUB_TOKEN` actually, it is [automatically created](https://docs.github.com/en/free-pro-team@latest/actions/reference/authentication-in-a-workflow#about-the-github_token-secret)) From 79f6fdda71b5ac5996caba699586b72f9db1a1af Mon Sep 17 00:00:00 2001 From: Shane Krueger Date: Sat, 6 Nov 2021 21:54:36 -0400 Subject: [PATCH 4/4] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6c4da95..26e8808 100644 --- a/README.md +++ b/README.md @@ -141,7 +141,7 @@ If you publish package with a scoped name to npm, change the name to something l If you publish your package to npm only, and don't want to publish to GitHub Packages, then delete the lines from `- name: Setup .npmrc file to publish to GitHub Packages` to the end of the file in **.github/workflows/publish.yml**. -(You might have noticed `secret.GITHUB_TOKEN` in **.github/workflows/test.yml**. You don't need to set up a secret named `GITHUB_TOKEN` actually, it is [automatically created](https://docs.github.com/en/free-pro-team@latest/actions/reference/authentication-in-a-workflow#about-the-github_token-secret)) +(You might have noticed `secret.GITHUB_TOKEN` in **.github/workflows/publish.yml**. You don't need to set up a secret named `GITHUB_TOKEN` actually, it is [automatically created](https://docs.github.com/en/free-pro-team@latest/actions/reference/authentication-in-a-workflow#about-the-github_token-secret)) ### Publish