From 29c2e740b2b5d7993b636947b4d29d6509061bd6 Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Fri, 20 Dec 2024 21:57:41 -0600 Subject: [PATCH 1/2] test(legacy[session]) Stabilize assertion =================================== FAILURES =================================== ______________________________ test_select_window ______________________________ [gw0] linux -- Python 3.13.0 /home/runner/work/libtmux/libtmux/.venv/bin/python tests/legacy_api/test_session.py:51: in test_select_window assert selected_window1.__dict__ == attached_window1.__dict__ E AssertionError: assert {'active_wind...e': None, ...} == {'active_wind...e': None, ...} E E Omitting 125 identical items, use -vv to show E Differing items: E {'cursor_x': '0'} != {'cursor_x': '56'} E Use -v to get more diff attached_window1 = Window(@1 1:bash, Session($1 libtmux_yphmur0x)) selected_window1 = Window(@1 1:bash, Session($1 libtmux_yphmur0x)) session = Session($1 libtmux_yphmur0x) window_base_index = 1 window_count = 2 window_idx = '1' ---------- coverage: platform linux, python 3.13.0-final-0 ----------- Coverage XML written to file coverage.xml =========================== short test summary info ============================ FAILED tests/legacy_api/test_session.py::test_select_window - AssertionError: assert {'active_wind...e': None, ...} == {'active_wind...e': None, ...} Omitting 125 identical items, use -vv to show Differing items: {'cursor_x': '0'} != {'cursor_x': '56'} Use -v to get more diff ============= 1 failed, 439 passed, 12 skipped, 2 rerun in 17.[92](https://github.com/tmux-python/libtmux/actions/runs/12441319490/job/34738031175#step:12:93)s ============== ============================= test session starts ============================== created: 4/4 workers 4 workers [452 items] ........................................................................ [ 15%] .....s...............................................s.s................ [ 31%] ..............................................s...R........R.......Fs.s. [ 47%] .................................................R..s...........ss...... [ 63%] .......................s..s.....s.....................s.s.s..s....s.s... [ 78%] ........................................................................ [ 94%] ....................... [100%] =================================== FAILURES =================================== ______________________________ test_select_window ______________________________ [gw0] linux -- Python 3.13.0 /home/runner/work/libtmux/libtmux/.venv/bin/python tests/legacy_api/test_session.py:61: in test_select_window assert selected_window2.__dict__ == attached_window2.__dict__ E AssertionError: assert {'active_wind...e': None, ...} == {'active_wind...e': None, ...} E E Omitting 125 identical items, use -vv to show E Differing items: E {'cursor_x': '0'} != {'cursor_x': '56'} E Use -v to get more diff attached_window1 = Window(@1 1:bash, Session($1 libtmux__xf1mgsj)) attached_window2 = Window(@2 2:test_window, Session($1 libtmux__xf1mgsj)) selected_window1 = Window(@1 1:bash, Session($1 libtmux__xf1mgsj)) selected_window2 = Window(@2 2:test_window, Session($1 libtmux__xf1mgsj)) session = Session($1 libtmux__xf1mgsj) window_base_index = 1 window_count = 2 window_idx = '1' =============================== warnings summary =============================== src/libtmux/pane.py::libtmux.pane.Pane.kill :1: UserWarning: resize() requires tmux 2.9 or newer tests/legacy_api/test_window.py::test_split_window_size /home/runner/work/libtmux/libtmux/tests/legacy_api/test_window.py:185: UserWarning: resize() requires tmux 2.9 or newer window.resize(height=100, width=100) tests/legacy_api/test_window.py::test_split_percentage /home/runner/work/libtmux/libtmux/tests/legacy_api/test_window.py:1[68](https://github.com/tmux-python/libtmux/actions/runs/12440365752/job/34735725442#step:12:69): UserWarning: resize() requires tmux 2.9 or newer window.resize(height=100, width=100) tests/test_pane.py::test_split_pane_size /home/runner/work/libtmux/libtmux/tests/test_pane.py:279: UserWarning: resize() requires tmux 2.9 or newer window.resize(height=100, width=100) tests/test_window.py::test_split_size /home/runner/work/libtmux/libtmux/tests/test_window.py:182: UserWarning: resize() requires tmux 2.9 or newer window.resize(height=100, width=100) -- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html ---------- coverage: platform linux, python 3.13.0-final-0 ----------- Coverage XML written to file coverage.xml =========================== short test summary info ============================ FAILED tests/legacy_api/test_session.py::test_select_window - AssertionError: assert {'active_wind...e': None, ...} == {'active_wind...e': None, ...} Omitting 125 identical items, use -vv to show Differing items: {'cursor_x': '0'} != {'cursor_x': '56'} Use -v to get more diff ======= 1 failed, 433 passed, 18 skipped, 5 warnings, 3 rerun in 17.00s ======== --- tests/test_session.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/test_session.py b/tests/test_session.py index a58046220..f4eec5d58 100644 --- a/tests/test_session.py +++ b/tests/test_session.py @@ -49,8 +49,7 @@ def test_select_window(session: Session) -> None: assert isinstance(selected_window1, Window) active_window1 = session.active_window - assert selected_window1 == active_window1 - assert selected_window1.__dict__ == active_window1.__dict__ + assert selected_window1.id == active_window1.id # again: tmux selects a window, moves to it, shows it as # active_window @@ -58,12 +57,10 @@ def test_select_window(session: Session) -> None: assert isinstance(selected_window2, Window) active_window2 = session.active_window - assert selected_window2 == active_window2 - assert selected_window2.__dict__ == active_window2.__dict__ + assert selected_window2.id == active_window2.id # assure these windows were really different - assert selected_window1 != selected_window2 - assert selected_window1.__dict__ != selected_window2.__dict__ + assert selected_window1.id != selected_window2.id def test_select_window_returns_Window(session: Session) -> None: From b11ef117808507da0226bc4be355cc281d366f74 Mon Sep 17 00:00:00 2001 From: Tony Narlock Date: Fri, 20 Dec 2024 22:00:35 -0600 Subject: [PATCH 2/2] docs(CHANGES) Note `test_select_window` stability fix --- CHANGES | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES b/CHANGES index 9de507736..1e5b82d84 100644 --- a/CHANGES +++ b/CHANGES @@ -24,6 +24,7 @@ $ pip install --user --upgrade --pre libtmux ```sh ruff check --select ALL . --fix --unsafe-fixes --preview --show-fixes; ruff format . ``` +- Tests: Stability fixes for legacy `test_select_pane` test (#552) ## libtmux 0.39.0 (2024-11-26)