Skip to content

feat: add no-test-id-queries rule #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 13, 2025
Merged

feat: add no-test-id-queries rule #1006

merged 6 commits into from
May 13, 2025
+167 −1

Conversation

StyleShit
Copy link
Contributor

Closes #279

@Belco90 Belco90 self-requested a review May 12, 2025 06:01
@codecov Codecov
Copy link

codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (26d360e) to head (6ce243a).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   96.27%   96.29%   +0.01%     
==========================================
  Files          46       47       +1     
  Lines        2472     2481       +9     
  Branches     1025     1026       +1     
==========================================
+ Hits         2380     2389       +9     
  Misses         92       92

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Belco90
Belco90 requested changes May 12, 2025
View reviewed changes
@StyleShit StyleShit requested a review from Belco90 May 12, 2025 08:11
Belco90
Belco90 requested changes May 12, 2025
View reviewed changes
@Belco90 Belco90 added the new rule New rule to be included in the plugin label May 12, 2025
@StyleShit StyleShit requested a review from Belco90 May 12, 2025 13:46
@Belco90 Belco90 enabled auto-merge May 12, 2025 13:51
@Belco90 Belco90 disabled auto-merge May 12, 2025 13:51
@Belco90 Belco90 added this pull request to the merge queue May 13, 2025
@Belco90 Belco90 removed this pull request from the merge queue due to a manual request May 13, 2025
@Belco90 Belco90 merged commit abe42cd into testing-library:main May 13, 2025
31 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Belco90
Copy link
Member

Belco90 commented May 13, 2025

@all-contributors please add @StyleShit for code, test, docs

@allcontributors allcontributors bot mentioned this pull request May 13, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @StyleShit! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees

@StyleShit StyleShit

Labels
new rule New rule to be included in the plugin released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New rule suggestion: no-test-id-queries
2 participants
@StyleShit @Belco90