diff --git a/apps/example-app/src/app/examples/05-component-provider.ts b/apps/example-app/src/app/examples/05-component-provider.ts
index 1f345b9..2d66b07 100644
--- a/apps/example-app/src/app/examples/05-component-provider.ts
+++ b/apps/example-app/src/app/examples/05-component-provider.ts
@@ -21,7 +21,7 @@ export class CounterService {
@Component({
standalone: true,
- selector: 'app-fixture',
+ selector: 'atl-fixture',
template: `
{{ counter.value() }}
diff --git a/apps/example-app/src/app/examples/06-with-ngrx-store.ts b/apps/example-app/src/app/examples/06-with-ngrx-store.ts
index b1db1d4..8702843 100644
--- a/apps/example-app/src/app/examples/06-with-ngrx-store.ts
+++ b/apps/example-app/src/app/examples/06-with-ngrx-store.ts
@@ -18,7 +18,7 @@ const selectValue = createSelector(
@Component({
standalone: true,
imports: [AsyncPipe],
- selector: 'app-fixture',
+ selector: 'atl-fixture',
template: `
{{ value | async }}
diff --git a/apps/example-app/src/app/examples/07-with-ngrx-mock-store.ts b/apps/example-app/src/app/examples/07-with-ngrx-mock-store.ts
index 7754bf1..915a88d 100644
--- a/apps/example-app/src/app/examples/07-with-ngrx-mock-store.ts
+++ b/apps/example-app/src/app/examples/07-with-ngrx-mock-store.ts
@@ -10,10 +10,12 @@ export const selectItems = createSelector(
@Component({
standalone: true,
imports: [AsyncPipe, NgForOf],
- selector: 'app-fixture',
+ selector: 'atl-fixture',
template: `
- - {{ item }}
+ -
+
+
`,
})
diff --git a/apps/example-app/src/app/examples/08-directive.spec.ts b/apps/example-app/src/app/examples/08-directive.spec.ts
index 8b70b38..28a41e9 100644
--- a/apps/example-app/src/app/examples/08-directive.spec.ts
+++ b/apps/example-app/src/app/examples/08-directive.spec.ts
@@ -6,7 +6,7 @@ import { SpoilerDirective } from './08-directive';
test('it is possible to test directives with container component', async () => {
@Component({
- template: ``,
+ template: ``,
imports: [SpoilerDirective],
standalone: true,
})
@@ -32,7 +32,7 @@ test('it is possible to test directives with container component', async () => {
test('it is possible to test directives', async () => {
const user = userEvent.setup();
- await render('', {
+ await render('', {
imports: [SpoilerDirective],
});
@@ -55,7 +55,7 @@ test('it is possible to test directives with props', async () => {
const hidden = 'SPOILER ALERT';
const visible = 'There is nothing to see here ...';
- await render('', {
+ await render('', {
imports: [SpoilerDirective],
componentProperties: {
hidden,
@@ -80,7 +80,7 @@ test('it is possible to test directives with props in template', async () => {
const hidden = 'SPOILER ALERT';
const visible = 'There is nothing to see here ...';
- await render(``, {
+ await render(``, {
imports: [SpoilerDirective],
});
diff --git a/apps/example-app/src/app/examples/08-directive.ts b/apps/example-app/src/app/examples/08-directive.ts
index 40548b1..63efe41 100644
--- a/apps/example-app/src/app/examples/08-directive.ts
+++ b/apps/example-app/src/app/examples/08-directive.ts
@@ -2,7 +2,7 @@ import { Directive, HostListener, ElementRef, Input, OnInit } from '@angular/cor
@Directive({
standalone: true,
- selector: '[appSpoiler]',
+ selector: '[atlSpoiler]',
})
export class SpoilerDirective implements OnInit {
@Input() hidden = 'SPOILER';
diff --git a/apps/example-app/src/app/examples/09-router.ts b/apps/example-app/src/app/examples/09-router.ts
index 888d7fd..e46773b 100644
--- a/apps/example-app/src/app/examples/09-router.ts
+++ b/apps/example-app/src/app/examples/09-router.ts
@@ -6,7 +6,7 @@ import { map } from 'rxjs/operators';
@Component({
standalone: true,
imports: [RouterLink, RouterOutlet],
- selector: 'app-main',
+ selector: 'atl-main',
template: `
Load one | Load two |
Load three |
@@ -21,7 +21,7 @@ export class RootComponent {}
@Component({
standalone: true,
imports: [RouterLink, AsyncPipe],
- selector: 'app-detail',
+ selector: 'atl-detail',
template: `
Detail {{ id | async }}
@@ -40,7 +40,7 @@ export class DetailComponent {
@Component({
standalone: true,
- selector: 'app-detail-hidden',
+ selector: 'atl-detail-hidden',
template: ' You found the treasure! ',
})
export class HiddenDetailComponent {}
diff --git a/apps/example-app/src/app/examples/10-inject-token-dependency.ts b/apps/example-app/src/app/examples/10-inject-token-dependency.ts
index 6a17d53..f7b2f66 100644
--- a/apps/example-app/src/app/examples/10-inject-token-dependency.ts
+++ b/apps/example-app/src/app/examples/10-inject-token-dependency.ts
@@ -4,7 +4,7 @@ export const DATA = new InjectionToken<{ text: string }>('Components Data');
@Component({
standalone: true,
- selector: 'app-fixture',
+ selector: 'atl-fixture',
template: ' {{ data.text }} ',
})
export class DataInjectedComponent {
diff --git a/apps/example-app/src/app/examples/11-ng-content.spec.ts b/apps/example-app/src/app/examples/11-ng-content.spec.ts
index 2f91025..468a3f2 100644
--- a/apps/example-app/src/app/examples/11-ng-content.spec.ts
+++ b/apps/example-app/src/app/examples/11-ng-content.spec.ts
@@ -5,7 +5,7 @@ import { CellComponent } from './11-ng-content';
test('it is possible to test ng-content without selector', async () => {
const projection = 'it should be showed into a p element!';
- await render(`${projection}`, {
+ await render(`${projection}`, {
imports: [CellComponent],
});
diff --git a/apps/example-app/src/app/examples/11-ng-content.ts b/apps/example-app/src/app/examples/11-ng-content.ts
index d444683..0dd668b 100644
--- a/apps/example-app/src/app/examples/11-ng-content.ts
+++ b/apps/example-app/src/app/examples/11-ng-content.ts
@@ -2,7 +2,7 @@ import { Component, ChangeDetectionStrategy } from '@angular/core';
@Component({
standalone: true,
- selector: 'app-fixture',
+ selector: 'atl-fixture',
template: `
diff --git a/apps/example-app/src/app/examples/12-service-component.ts b/apps/example-app/src/app/examples/12-service-component.ts
index 2aed165..1746eb2 100644
--- a/apps/example-app/src/app/examples/12-service-component.ts
+++ b/apps/example-app/src/app/examples/12-service-component.ts
@@ -19,7 +19,7 @@ export class CustomersService {
@Component({
standalone: true,
imports: [AsyncPipe, NgForOf],
- selector: 'app-fixture',
+ selector: 'atl-fixture',
template: `
-
diff --git a/apps/example-app/src/app/examples/13-scrolling.component.ts b/apps/example-app/src/app/examples/13-scrolling.component.ts
index 7d7b2e7..6a36ed8 100644
--- a/apps/example-app/src/app/examples/13-scrolling.component.ts
+++ b/apps/example-app/src/app/examples/13-scrolling.component.ts
@@ -4,7 +4,7 @@ import { ScrollingModule } from '@angular/cdk/scrolling';
@Component({
standalone: true,
imports: [ScrollingModule],
- selector: 'app-cdk-virtual-scroll-overview-example',
+ selector: 'atl-cdk-virtual-scroll-overview-example',
template: `
{{ item }}
diff --git a/apps/example-app/src/app/examples/14-async-component.spec.ts b/apps/example-app/src/app/examples/14-async-component.spec.ts
index b54740a..5cfd3e0 100644
--- a/apps/example-app/src/app/examples/14-async-component.spec.ts
+++ b/apps/example-app/src/app/examples/14-async-component.spec.ts
@@ -3,7 +3,6 @@ import { render, screen, fireEvent } from '@testing-library/angular';
import { AsyncComponent } from './14-async-component';
-// eslint-disable-next-line jest/no-disabled-tests
test.skip('can use fakeAsync utilities', fakeAsync(async () => {
await render(AsyncComponent);
diff --git a/apps/example-app/src/app/examples/14-async-component.ts b/apps/example-app/src/app/examples/14-async-component.ts
index f87732a..64d7aaa 100644
--- a/apps/example-app/src/app/examples/14-async-component.ts
+++ b/apps/example-app/src/app/examples/14-async-component.ts
@@ -6,7 +6,7 @@ import { delay, filter, mapTo } from 'rxjs/operators';
@Component({
standalone: true,
imports: [AsyncPipe, NgIf],
- selector: 'app-fixture',
+ selector: 'atl-fixture',
template: `
{{ data }}
diff --git a/apps/example-app/src/app/examples/15-dialog.component.spec.ts b/apps/example-app/src/app/examples/15-dialog.component.spec.ts
index 97ad829..017afdc 100644
--- a/apps/example-app/src/app/examples/15-dialog.component.spec.ts
+++ b/apps/example-app/src/app/examples/15-dialog.component.spec.ts
@@ -38,7 +38,7 @@ test('closes the dialog via the backdrop', async () => {
const dialogTitleControl = await screen.findByRole('heading', { name: /dialog title/i });
expect(dialogTitleControl).toBeInTheDocument();
- // eslint-disable-next-line @typescript-eslint/no-non-null-assertion, testing-library/no-node-access
+ // eslint-disable-next-line testing-library/no-node-access
await user.click(document.querySelector('.cdk-overlay-backdrop')!);
expect(screen.queryByRole('dialog')).not.toBeInTheDocument();
diff --git a/apps/example-app/src/app/examples/15-dialog.component.ts b/apps/example-app/src/app/examples/15-dialog.component.ts
index f6c8970..029ee64 100644
--- a/apps/example-app/src/app/examples/15-dialog.component.ts
+++ b/apps/example-app/src/app/examples/15-dialog.component.ts
@@ -4,7 +4,7 @@ import { MatDialog, MatDialogModule, MatDialogRef } from '@angular/material/dial
@Component({
standalone: true,
imports: [MatDialogModule],
- selector: 'app-dialog-overview-example',
+ selector: 'atl-dialog-overview-example',
template: '',
})
export class DialogComponent {
@@ -18,7 +18,7 @@ export class DialogComponent {
@Component({
standalone: true,
imports: [MatDialogModule],
- selector: 'app-dialog-overview-example-dialog',
+ selector: 'atl-dialog-overview-example-dialog',
template: `
Dialog Title
Dialog content
diff --git a/apps/example-app/src/app/examples/16-input-getter-setter.ts b/apps/example-app/src/app/examples/16-input-getter-setter.ts
index a9097a4..4c18900 100644
--- a/apps/example-app/src/app/examples/16-input-getter-setter.ts
+++ b/apps/example-app/src/app/examples/16-input-getter-setter.ts
@@ -2,7 +2,7 @@ import { Component, Input } from '@angular/core';
@Component({
standalone: true,
- selector: 'app-fixture',
+ selector: 'atl-fixture',
template: `
{{ derivedValue }}
{{ value }}
diff --git a/apps/example-app/src/app/examples/17-component-with-attribute-selector.spec.ts b/apps/example-app/src/app/examples/17-component-with-attribute-selector.spec.ts
index ba69f70..f33dee3 100644
--- a/apps/example-app/src/app/examples/17-component-with-attribute-selector.spec.ts
+++ b/apps/example-app/src/app/examples/17-component-with-attribute-selector.spec.ts
@@ -5,7 +5,7 @@ import { ComponentWithAttributeSelectorComponent } from './17-component-with-att
// for components with attribute selectors!
test('is possible to set input of component with attribute selector through template', async () => {
await render(
- ``,
+ ``,
{
imports: [ComponentWithAttributeSelectorComponent],
},
diff --git a/apps/example-app/src/app/examples/17-component-with-attribute-selector.ts b/apps/example-app/src/app/examples/17-component-with-attribute-selector.ts
index ac2a25d..930032c 100644
--- a/apps/example-app/src/app/examples/17-component-with-attribute-selector.ts
+++ b/apps/example-app/src/app/examples/17-component-with-attribute-selector.ts
@@ -2,7 +2,7 @@ import { Component, Input } from '@angular/core';
@Component({
standalone: true,
- selector: 'app-fixture-component-with-attribute-selector[value]',
+ selector: 'atl-fixture-component-with-attribute-selector[value]',
template: ` {{ value }} `,
})
export class ComponentWithAttributeSelectorComponent {
diff --git a/apps/example-app/src/app/examples/19-standalone-component.ts b/apps/example-app/src/app/examples/19-standalone-component.ts
index efcf088..95eae3d 100644
--- a/apps/example-app/src/app/examples/19-standalone-component.ts
+++ b/apps/example-app/src/app/examples/19-standalone-component.ts
@@ -1,17 +1,17 @@
import { Component, Input } from '@angular/core';
@Component({
- selector: 'app-standalone',
+ selector: 'atl-standalone',
template: `Standalone Component
`,
standalone: true,
})
export class StandaloneComponent {}
@Component({
- selector: 'app-standalone-with-child',
+ selector: 'atl-standalone-with-child',
template: `Hi {{ name }}
This has a child
- `,
+ `,
standalone: true,
imports: [StandaloneComponent],
})
diff --git a/apps/example-app/src/app/examples/20-test-harness.spec.ts b/apps/example-app/src/app/examples/20-test-harness.spec.ts
index 6e4d9e3..4a88a58 100644
--- a/apps/example-app/src/app/examples/20-test-harness.spec.ts
+++ b/apps/example-app/src/app/examples/20-test-harness.spec.ts
@@ -6,9 +6,8 @@ import userEvent from '@testing-library/user-event';
import { HarnessComponent } from './20-test-harness';
-// eslint-disable-next-line jest/no-disabled-tests
test.skip('can be used with TestHarness', async () => {
- const view = await render(``, {
+ const view = await render(``, {
imports: [HarnessComponent],
});
const loader = TestbedHarnessEnvironment.documentRootLoader(view.fixture);
@@ -21,7 +20,6 @@ test.skip('can be used with TestHarness', async () => {
expect(await snackbarHarness.getMessage()).toMatch(/Pizza Party!!!/i);
});
-// eslint-disable-next-line jest/no-disabled-tests
test.skip('can be used in combination with TestHarness', async () => {
const user = userEvent.setup();
diff --git a/apps/example-app/src/app/examples/20-test-harness.ts b/apps/example-app/src/app/examples/20-test-harness.ts
index 08d6afd..8e5e407 100644
--- a/apps/example-app/src/app/examples/20-test-harness.ts
+++ b/apps/example-app/src/app/examples/20-test-harness.ts
@@ -3,7 +3,7 @@ import { MatButtonModule } from '@angular/material/button';
import { MatSnackBar, MatSnackBarModule } from '@angular/material/snack-bar';
@Component({
- selector: 'app-harness',
+ selector: 'atl-harness',
standalone: true,
imports: [MatButtonModule, MatSnackBarModule],
template: `
diff --git a/apps/example-app/src/app/examples/21-deferable-view.component.ts b/apps/example-app/src/app/examples/21-deferable-view.component.ts
index ce47a58..7b66d85 100644
--- a/apps/example-app/src/app/examples/21-deferable-view.component.ts
+++ b/apps/example-app/src/app/examples/21-deferable-view.component.ts
@@ -1,7 +1,7 @@
import { Component } from '@angular/core';
@Component({
- selector: 'app-deferable-view-child',
+ selector: 'atl-deferable-view-child',
template: ` Hello from deferred child component
`,
standalone: true,
})
@@ -10,7 +10,7 @@ export class DeferableViewChildComponent {}
@Component({
template: `
@defer (on timer(2s)) {
-
+
} @placeholder {
Hello from placeholder
} @loading {
diff --git a/apps/example-app/src/app/examples/22-signal-inputs.component.spec.ts b/apps/example-app/src/app/examples/22-signal-inputs.component.spec.ts
index 470e639..355e8ae 100644
--- a/apps/example-app/src/app/examples/22-signal-inputs.component.spec.ts
+++ b/apps/example-app/src/app/examples/22-signal-inputs.component.spec.ts
@@ -60,7 +60,7 @@ test('output emits a value', async () => {
age: '45',
},
on: {
- submit: submitFn,
+ submitValue: submitFn,
},
});
diff --git a/apps/example-app/src/app/examples/22-signal-inputs.component.ts b/apps/example-app/src/app/examples/22-signal-inputs.component.ts
index dfe6bd0..27ed23b 100644
--- a/apps/example-app/src/app/examples/22-signal-inputs.component.ts
+++ b/apps/example-app/src/app/examples/22-signal-inputs.component.ts
@@ -2,7 +2,7 @@ import { Component, computed, input, model, numberAttribute, output } from '@ang
import { FormsModule } from '@angular/forms';
@Component({
- selector: 'app-signal-input',
+ selector: 'atl-signal-input',
template: `
{{ greetings() }} {{ name() }} of {{ age() }} years old
{{ greetingMessage() }}
@@ -18,11 +18,11 @@ export class SignalInputComponent {
});
age = input.required({ transform: numberAttribute });
name = model.required();
- submit = output();
+ submitValue = output();
greetingMessage = computed(() => `${this.greetings()} ${this.name()} of ${this.age()} years old`);
submitName() {
- this.submit.emit(this.name());
+ this.submitValue.emit(this.name());
}
}
diff --git a/apps/example-app/src/test-setup.ts b/apps/example-app/src/test-setup.ts
index 0da94a0..96bfd34 100644
--- a/apps/example-app/src/test-setup.ts
+++ b/apps/example-app/src/test-setup.ts
@@ -1,2 +1,4 @@
-import 'jest-preset-angular/setup-jest';
+import { setupZoneTestEnv } from 'jest-preset-angular/setup-env/zone';
import '@testing-library/jest-dom';
+
+setupZoneTestEnv();
diff --git a/eslint.config.cjs b/eslint.config.cjs
new file mode 100644
index 0000000..9e951e7
--- /dev/null
+++ b/eslint.config.cjs
@@ -0,0 +1,7 @@
+// @ts-check
+
+// TODO - https://github.com/nrwl/nx/issues/22576
+
+/** @type {import('@typescript-eslint/utils/ts-eslint').FlatConfig.ConfigPromise} */
+const config = (async () => (await import('./eslint.config.mjs')).default)();
+module.exports = config;
diff --git a/eslint.config.mjs b/eslint.config.mjs
index 182ef0f..f6a45ff 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -12,8 +12,6 @@ export default tseslint.config(
...tseslint.configs.recommended,
...tseslint.configs.stylistic,
...angular.configs.tsRecommended,
- ...jestDom.configs.recommended,
- ...testingLibrary.configs.angular,
],
processor: angular.processInlineTemplates,
rules: {
@@ -33,8 +31,28 @@ export default tseslint.config(
style: "kebab-case",
},
],
+ "@typescript-eslint/no-explicit-any": "off",
+ "@typescript-eslint/no-unused-vars": [
+ "error",
+ {
+ "argsIgnorePattern": "^_",
+ "varsIgnorePattern": "^_",
+ "caughtErrorsIgnorePattern": "^_"
+ }
+ ],
+ // These are needed for test cases
+ "@angular-eslint/prefer-standalone": "off",
+ "@angular-eslint/no-input-rename": "off",
+ "@angular-eslint/no-input-rename": "off",
},
},
+ {
+ files: ["**/*.spec.ts"],
+ extends: [
+ jestDom.configs["flat/recommended"],
+ testingLibrary.configs["flat/angular"],
+ ],
+ },
{
files: ["**/*.html"],
extends: [
diff --git a/nx.json b/nx.json
index df534f7..a308e67 100644
--- a/nx.json
+++ b/nx.json
@@ -82,7 +82,7 @@
}
},
"@nx/eslint:lint": {
- "inputs": ["default", "{workspaceRoot}/.eslintrc.json"],
+ "inputs": ["default", "{workspaceRoot}/eslint.config.cjs"],
"cache": true
}
},
@@ -96,7 +96,7 @@
"!{projectRoot}/karma.conf.js",
"!{projectRoot}/**/?(*.)+(spec|test).[jt]s?(x)?(.snap)",
"!{projectRoot}/jest.config.[jt]s",
- "!{projectRoot}/.eslintrc.json",
+ "!{projectRoot}/eslint.config.cjs",
"!{projectRoot}/src/test-setup.[jt]s"
]
},
diff --git a/package.json b/package.json
index ea92033..614a2ee 100644
--- a/package.json
+++ b/package.json
@@ -56,6 +56,7 @@
"@angular/compiler-cli": "19.0.1",
"@angular/forms": "19.0.1",
"@angular/language-service": "19.0.1",
+ "@eslint/eslintrc": "^2.1.1",
"@nx/eslint": "20.3.0",
"@nx/eslint-plugin": "20.3.0",
"@nx/jest": "20.3.0",
@@ -70,13 +71,13 @@
"@types/jest": "29.5.14",
"@types/node": "22.10.1",
"@types/testing-library__jasmine-dom": "^1.3.4",
- "@typescript-eslint/eslint-plugin": "7.16.0",
- "@typescript-eslint/parser": "7.16.0",
+ "@typescript-eslint/types": "^8.19.0",
"@typescript-eslint/utils": "^8.19.0",
"angular-eslint": "^19.0.2",
"autoprefixer": "^10.4.20",
"cpy-cli": "^5.0.0",
- "eslint": "8.57.0",
+ "eslint": "^9.8.0",
+ "eslint-config-prettier": "^9.0.0",
"eslint-plugin-jest-dom": "~5.5.0",
"eslint-plugin-testing-library": "~7.1.1",
"jasmine-core": "4.2.0",
diff --git a/projects/testing-library/.eslintrc.json b/projects/testing-library/.eslintrc.json
deleted file mode 100644
index 5a9d690..0000000
--- a/projects/testing-library/.eslintrc.json
+++ /dev/null
@@ -1,62 +0,0 @@
-{
- "extends": "../../.eslintrc.json",
- "ignorePatterns": ["!**/*"],
- "overrides": [
- {
- "files": ["*.ts"],
- "rules": {
- "@typescript-eslint/ban-ts-comment": "off",
- "@typescript-eslint/no-unused-vars": [
- "error",
- {
- "argsIgnorePattern": "^_",
- "varsIgnorePattern": "^_",
- "caughtErrorsIgnorePattern": "^_"
- }
- ]
- }
- },
- {
- "files": ["*.ts"],
- "extends": ["plugin:@nx/angular", "plugin:@angular-eslint/template/process-inline-templates"],
- "parserOptions": {
- "project": ["projects/testing-library/tsconfig.*?.json"]
- },
- "rules": {
- "@typescript-eslint/ban-ts-comment": "off",
- "@angular-eslint/directive-selector": [
- "error",
- {
- "type": "attribute",
- "prefix": "atl",
- "style": "camelCase"
- }
- ],
- "@angular-eslint/component-selector": [
- "error",
- {
- "type": "element",
- "prefix": "atl",
- "style": "kebab-case"
- }
- ]
- }
- },
- {
- "files": ["*.spec.ts"],
- "env": {
- "jest": true
- },
- "extends": ["plugin:jest/recommended", "plugin:jest/style", "plugin:jest-dom/recommended"],
- "rules": {
- "jest/consistent-test-it": ["error"],
- "jest/expect-expect": "off"
- }
- },
- {
- "files": ["*.html"],
- "extends": ["plugin:@nx/angular-template"],
- "rules": {}
- }
- ]
-}
diff --git a/projects/testing-library/eslint.config.cjs b/projects/testing-library/eslint.config.cjs
new file mode 100644
index 0000000..9e951e7
--- /dev/null
+++ b/projects/testing-library/eslint.config.cjs
@@ -0,0 +1,7 @@
+// @ts-check
+
+// TODO - https://github.com/nrwl/nx/issues/22576
+
+/** @type {import('@typescript-eslint/utils/ts-eslint').FlatConfig.ConfigPromise} */
+const config = (async () => (await import('./eslint.config.mjs')).default)();
+module.exports = config;
diff --git a/projects/testing-library/eslint.config.mjs b/projects/testing-library/eslint.config.mjs
index 95ad35f..c77ae98 100644
--- a/projects/testing-library/eslint.config.mjs
+++ b/projects/testing-library/eslint.config.mjs
@@ -1,8 +1,6 @@
import tseslint from "typescript-eslint";
import rootConfig from "../../eslint.config.mjs";
-const rootConfig = require('../../eslint.config.js');
-
-module.exports = tseslint.config(
+export default tseslint.config(
...rootConfig,
-);
\ No newline at end of file
+);
diff --git a/projects/testing-library/jest.config.ts b/projects/testing-library/jest.config.ts
index 189e52f..bc5a665 100644
--- a/projects/testing-library/jest.config.ts
+++ b/projects/testing-library/jest.config.ts
@@ -1,4 +1,3 @@
-/* eslint-disable */
export default {
displayName: {
name: 'ATL',
diff --git a/projects/testing-library/schematics/migrations/dtl-as-dev-dependency/index.spec.ts b/projects/testing-library/schematics/migrations/dtl-as-dev-dependency/index.spec.ts
index a3c0fd1..ebc3922 100644
--- a/projects/testing-library/schematics/migrations/dtl-as-dev-dependency/index.spec.ts
+++ b/projects/testing-library/schematics/migrations/dtl-as-dev-dependency/index.spec.ts
@@ -16,7 +16,6 @@ test('adds DTL to devDependencies', async () => {
});
test('ignores if DTL is already listed as a dev dependency', async () => {
- // eslint-disable-next-line @typescript-eslint/naming-convention
const tree = await setup({ devDependencies: { '@testing-library/dom': '^9.0.0' } });
const pkg = tree.readContent('package.json');
@@ -24,7 +23,6 @@ test('ignores if DTL is already listed as a dev dependency', async () => {
});
test('ignores if DTL is already listed as a dependency', async () => {
- // eslint-disable-next-line @typescript-eslint/naming-convention
const tree = await setup({ dependencies: { '@testing-library/dom': '^11.0.0' } });
const pkg = tree.readContent('package.json');
diff --git a/projects/testing-library/schematics/ng-add/schema.ts b/projects/testing-library/schematics/ng-add/schema.ts
index dc14633..b0dcd22 100644
--- a/projects/testing-library/schematics/ng-add/schema.ts
+++ b/projects/testing-library/schematics/ng-add/schema.ts
@@ -1,4 +1,3 @@
-// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface Schema {
installJestDom: boolean;
installUserEvent: boolean;
diff --git a/projects/testing-library/src/lib/models.ts b/projects/testing-library/src/lib/models.ts
index 0c34aa8..159ac41 100644
--- a/projects/testing-library/src/lib/models.ts
+++ b/projects/testing-library/src/lib/models.ts
@@ -243,7 +243,7 @@ export interface RenderComponentOptions | { [alias: string]: unknown };
+ componentInputs?: Partial | Record;
/**
* @description
@@ -466,7 +466,7 @@ export interface ComponentOverride {
providers: any[];
}
-// eslint-disable-next-line @typescript-eslint/ban-types
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
export interface RenderTemplateOptions
extends RenderComponentOptions {
/**
diff --git a/projects/testing-library/src/lib/testing-library.ts b/projects/testing-library/src/lib/testing-library.ts
index 2ddf389..f498a89 100644
--- a/projects/testing-library/src/lib/testing-library.ts
+++ b/projects/testing-library/src/lib/testing-library.ts
@@ -560,7 +560,7 @@ async function waitForWrapper(
let inFakeAsync = true;
try {
tick(0);
- } catch (err) {
+ } catch {
inFakeAsync = false;
}
diff --git a/projects/testing-library/test-setup.ts b/projects/testing-library/test-setup.ts
index 8d79c74..be311bf 100644
--- a/projects/testing-library/test-setup.ts
+++ b/projects/testing-library/test-setup.ts
@@ -4,5 +4,4 @@ import { TextEncoder, TextDecoder } from 'util';
setupZoneTestEnv();
-// eslint-disable-next-line @typescript-eslint/naming-convention
Object.assign(global, { TextDecoder, TextEncoder });
diff --git a/projects/testing-library/tests/debug.spec.ts b/projects/testing-library/tests/debug.spec.ts
index e1ad1df..63ab7e6 100644
--- a/projects/testing-library/tests/debug.spec.ts
+++ b/projects/testing-library/tests/debug.spec.ts
@@ -14,11 +14,11 @@ test('debug', async () => {
jest.spyOn(console, 'log').mockImplementation();
const { debug } = await render(FixtureComponent);
- // eslint-disable-next-line testing-library/no-debug
+ // eslint-disable-next-line testing-library/no-debugging-utils
debug();
expect(console.log).toHaveBeenCalledWith(expect.stringContaining('rawr'));
- (console.log).mockRestore();
+ (console.log as any).mockRestore();
});
test('debug allows to be called with an element', async () => {
@@ -26,10 +26,10 @@ test('debug allows to be called with an element', async () => {
const { debug } = await render(FixtureComponent);
const btn = screen.getByTestId('btn');
- // eslint-disable-next-line testing-library/no-debug
+ // eslint-disable-next-line testing-library/no-debugging-utils
debug(btn);
expect(console.log).not.toHaveBeenCalledWith(expect.stringContaining('rawr'));
expect(console.log).toHaveBeenCalledWith(expect.stringContaining(`I'm a button`));
- (console.log).mockRestore();
+ (console.log as any).mockRestore();
});
diff --git a/projects/testing-library/tests/issues/issue-280.spec.ts b/projects/testing-library/tests/issues/issue-280.spec.ts
index 5e59534..711cbec 100644
--- a/projects/testing-library/tests/issues/issue-280.spec.ts
+++ b/projects/testing-library/tests/issues/issue-280.spec.ts
@@ -48,12 +48,12 @@ test('navigate to second page and back', async () => {
expect(await screen.findByText('Navigate')).toBeInTheDocument();
expect(await screen.findByText('first page')).toBeInTheDocument();
- userEvent.click(await screen.findByText('go to second'));
+ await userEvent.click(await screen.findByText('go to second'));
expect(await screen.findByText('second page')).toBeInTheDocument();
expect(await screen.findByText('navigate back')).toBeInTheDocument();
- userEvent.click(await screen.findByText('navigate back'));
+ await userEvent.click(await screen.findByText('navigate back'));
expect(await screen.findByText('first page')).toBeInTheDocument();
});
diff --git a/projects/testing-library/tests/issues/issue-389.spec.ts b/projects/testing-library/tests/issues/issue-389.spec.ts
index 03f25f7..626d388 100644
--- a/projects/testing-library/tests/issues/issue-389.spec.ts
+++ b/projects/testing-library/tests/issues/issue-389.spec.ts
@@ -6,7 +6,6 @@ import { render, screen } from '../../src/public_api';
template: `Hello {{ name }}`,
})
class TestComponent {
- // eslint-disable-next-line @angular-eslint/no-input-rename
@Input('aliasName') name = '';
}
diff --git a/projects/testing-library/tests/issues/issue-396-standalone-stub-child.spec.ts b/projects/testing-library/tests/issues/issue-396-standalone-stub-child.spec.ts
index 2da43b3..7be9913 100644
--- a/projects/testing-library/tests/issues/issue-396-standalone-stub-child.spec.ts
+++ b/projects/testing-library/tests/issues/issue-396-standalone-stub-child.spec.ts
@@ -42,7 +42,6 @@ class ChildComponent {}
selector: 'atl-child',
template: `Hello from stub`,
standalone: true,
- // eslint-disable-next-line @angular-eslint/no-host-metadata-property, @typescript-eslint/naming-convention
host: { 'collision-id': StubComponent.name },
})
class StubComponent {}
diff --git a/projects/testing-library/tests/issues/issue-398-component-without-host-id.spec.ts b/projects/testing-library/tests/issues/issue-398-component-without-host-id.spec.ts
index 4508d64..c775a2a 100644
--- a/projects/testing-library/tests/issues/issue-398-component-without-host-id.spec.ts
+++ b/projects/testing-library/tests/issues/issue-398-component-without-host-id.spec.ts
@@ -15,9 +15,7 @@ test('should re-create the app', async () => {
selector: 'atl-fixture',
standalone: true,
template: 'My title
',
- // eslint-disable-next-line @angular-eslint/no-host-metadata-property
host: {
- // eslint-disable-next-line @typescript-eslint/naming-convention
'[attr.id]': 'null', // this breaks the cleaning up of tests
},
})
diff --git a/projects/testing-library/tests/issues/issue-422-view-already-destroyed.spec.ts b/projects/testing-library/tests/issues/issue-422-view-already-destroyed.spec.ts
index 05e6e11..c4fa7a3 100644
--- a/projects/testing-library/tests/issues/issue-422-view-already-destroyed.spec.ts
+++ b/projects/testing-library/tests/issues/issue-422-view-already-destroyed.spec.ts
@@ -9,6 +9,7 @@ test('declaration specific dependencies should be available for components', asy
template: `Test
`,
})
class TestComponent {
+ // eslint-disable-next-line @typescript-eslint/no-empty-function
constructor(_elementRef: ElementRef) {}
}
diff --git a/projects/testing-library/tests/issues/issue-437.spec.ts b/projects/testing-library/tests/issues/issue-437.spec.ts
index 2d0e7c5..dbf2506 100644
--- a/projects/testing-library/tests/issues/issue-437.spec.ts
+++ b/projects/testing-library/tests/issues/issue-437.spec.ts
@@ -24,7 +24,6 @@ test('issue #437', async () => {
{ imports: [MatSidenavModule] },
);
- // eslint-disable-next-line testing-library/prefer-explicit-assert
await screen.findByTestId('test-button');
await user.click(screen.getByTestId('test-button'));
@@ -51,7 +50,6 @@ test('issue #437 with fakeTimers', async () => {
{ imports: [MatSidenavModule] },
);
- // eslint-disable-next-line testing-library/prefer-explicit-assert
await screen.findByTestId('test-button');
await user.click(screen.getByTestId('test-button'));
diff --git a/projects/testing-library/tests/issues/issue-493.spec.ts b/projects/testing-library/tests/issues/issue-493.spec.ts
index a49bc80..5d0e123 100644
--- a/projects/testing-library/tests/issues/issue-493.spec.ts
+++ b/projects/testing-library/tests/issues/issue-493.spec.ts
@@ -22,6 +22,6 @@ test('succeeds', async () => {
})
class DummyComponent {
value = input.required();
- // @ts-ignore
+ // @ts-expect-error http is unused but needed for the test
constructor(private http: HttpClient) {}
}
diff --git a/projects/testing-library/tests/render.spec.ts b/projects/testing-library/tests/render.spec.ts
index 52d318c..dc54ac5 100644
--- a/projects/testing-library/tests/render.spec.ts
+++ b/projects/testing-library/tests/render.spec.ts
@@ -37,7 +37,7 @@ describe('DTL functionality', () => {
it('creates queries and events', async () => {
const view = await render(FixtureComponent);
- /// We wish to test the utility function from `render` here.
+ // We wish to test the utility function from `render` here.
// eslint-disable-next-line testing-library/prefer-screen-queries
fireEvent.input(view.getByTestId('input'), { target: { value: 'a super awesome input' } });
// eslint-disable-next-line testing-library/prefer-screen-queries
@@ -72,7 +72,6 @@ describe('component with child', () => {
@Component({
selector: 'atl-child-fixture',
template: `A mock child fixture`,
- // eslint-disable-next-line @angular-eslint/no-host-metadata-property, @typescript-eslint/naming-convention
host: { 'collision-id': MockChildFixtureComponent.name },
})
class MockChildFixtureComponent {}
@@ -287,19 +286,19 @@ describe('on', () => {
// eslint-disable-next-line @typescript-eslint/no-empty-function
function _test(_on: OutputRefKeysWithCallback) {}
- // @ts-expect-error
+ // @ts-expect-error wrong event type
_test({ event: fnWithNumberArg });
_test({ event: fnWithVoidArg });
- // @ts-expect-error
+ // @ts-expect-error wrong event type
_test({ event: fnWithNumberArg });
_test({ event: fnWithMouseEventArg });
- // @ts-expect-error
+ // @ts-expect-error wrong event type
_test({ event: fnWithNumberArg });
_test({ event: fnWithStringArg });
- // @ts-expect-error
+ // @ts-expect-error wrong event type
_test({ event: fnWithNumberArg });
_test({ event: fnWithMouseEventArg });
@@ -392,11 +391,11 @@ describe('Angular component life-cycle hooks', () => {
const view = await render(FixtureWithNgOnChangesComponent, { componentProperties });
- /// We wish to test the utility function from `render` here.
+ // We wish to test the utility function from `render` here.
// eslint-disable-next-line testing-library/prefer-screen-queries
expect(view.getByText('Sarah')).toBeInTheDocument();
expect(nameChanged).toHaveBeenCalledWith('Sarah', true);
- /// expect `nameChanged` to be called before `nameInitialized`
+ // expect `nameChanged` to be called before `nameInitialized`
expect(nameChanged.mock.invocationCallOrder[0]).toBeLessThan(nameInitialized.mock.invocationCallOrder[0]);
expect(nameChanged).toHaveBeenCalledTimes(1);
});
@@ -408,11 +407,11 @@ describe('Angular component life-cycle hooks', () => {
const view = await render(FixtureWithNgOnChangesComponent, { componentInputs: componentInput });
- /// We wish to test the utility function from `render` here.
+ // We wish to test the utility function from `render` here.
// eslint-disable-next-line testing-library/prefer-screen-queries
expect(view.getByText('Sarah')).toBeInTheDocument();
expect(nameChanged).toHaveBeenCalledWith('Sarah', true);
- /// expect `nameChanged` to be called before `nameInitialized`
+ // expect `nameChanged` to be called before `nameInitialized`
expect(nameChanged.mock.invocationCallOrder[0]).toBeLessThan(nameInitialized.mock.invocationCallOrder[0]);
expect(nameChanged).toHaveBeenCalledTimes(1);
});
From d82582be72c03afa3fa10c800e07e87fb2aa227d Mon Sep 17 00:00:00 2001
From: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Date: Sat, 4 Jan 2025 13:27:14 +0100
Subject: [PATCH 3/4] ts-check
---
apps/example-app-karma/eslint.config.mjs | 2 ++
apps/example-app/eslint.config.mjs | 2 ++
eslint.config.mjs | 2 ++
projects/testing-library/eslint.config.mjs | 2 ++
4 files changed, 8 insertions(+)
diff --git a/apps/example-app-karma/eslint.config.mjs b/apps/example-app-karma/eslint.config.mjs
index c77ae98..8f627db 100644
--- a/apps/example-app-karma/eslint.config.mjs
+++ b/apps/example-app-karma/eslint.config.mjs
@@ -1,3 +1,5 @@
+// @ts-check
+
import tseslint from "typescript-eslint";
import rootConfig from "../../eslint.config.mjs";
diff --git a/apps/example-app/eslint.config.mjs b/apps/example-app/eslint.config.mjs
index 5b7a86c..0162584 100644
--- a/apps/example-app/eslint.config.mjs
+++ b/apps/example-app/eslint.config.mjs
@@ -1,3 +1,5 @@
+// @ts-check
+
import tseslint from "typescript-eslint";
import rootConfig from "../../eslint.config.mjs";
diff --git a/eslint.config.mjs b/eslint.config.mjs
index f6a45ff..95e031a 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -1,3 +1,5 @@
+// @ts-check
+
import eslint from "@eslint/js";
import tseslint from "typescript-eslint";
import angular from "angular-eslint";
diff --git a/projects/testing-library/eslint.config.mjs b/projects/testing-library/eslint.config.mjs
index c77ae98..8f627db 100644
--- a/projects/testing-library/eslint.config.mjs
+++ b/projects/testing-library/eslint.config.mjs
@@ -1,3 +1,5 @@
+// @ts-check
+
import tseslint from "typescript-eslint";
import rootConfig from "../../eslint.config.mjs";
From cda2d4a03f0731c0b4fdb69ad9a0f71c535a3d17 Mon Sep 17 00:00:00 2001
From: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Date: Sat, 4 Jan 2025 13:28:03 +0100
Subject: [PATCH 4/4] remove eslint-config-prettier
---
package.json | 1 -
1 file changed, 1 deletion(-)
diff --git a/package.json b/package.json
index 614a2ee..bbf0e3c 100644
--- a/package.json
+++ b/package.json
@@ -77,7 +77,6 @@
"autoprefixer": "^10.4.20",
"cpy-cli": "^5.0.0",
"eslint": "^9.8.0",
- "eslint-config-prettier": "^9.0.0",
"eslint-plugin-jest-dom": "~5.5.0",
"eslint-plugin-testing-library": "~7.1.1",
"jasmine-core": "4.2.0",