-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Consider moving of security:check documentation #4745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In addition... #4651 was merged in 2.3 but should be 2.5 as mentioned in #4651 (comment) |
@xelaris Can you create a pull request reverting the change in the 2.3 branch? |
Hey @xelaris! This is really great of you to catch - the whole point of rewriting the security chapter was to be more relevant, and remove things like this from it. So you're right - the question is, what's the right place for this? Perhaps we need a new cookbook entry about actually "securing" your Symfony app, for example:
... and probably more! That's a little bit more of an undertaking, but maybe something that would be good in this day and age of security? |
We could even recommend https://github.com/Roave/SecurityAdvisories to handle security issues in your deps (it forbids composer to select them in a composer update, with the same database than the security:check command) |
@weaverryan what about a new best practices chapter about Securing your application? (not to be mixed with Security) |
I think that's a very cool idea - makes sense as a cookbook article to me, and I think it could be a very useful reference section on what you should be doing. |
Closing it as "fixed" because the security checker now has its own article: http://symfony.com/doc/current/security/security_checker.html |
While reading the rewritten security chapter I came across https://github.com/symfony/symfony-docs/blob/2.3/book/security.rst#checking-for-known-security-vulnerabilities-in-dependencies
IMO this part should be moved somewhere else (however I don't know where yet), since there is thematically no analogy to the rest of the chapter. Everything is about Symfony's security system as the first three words are telling, but this is about security vulnerabilities in dependencies.
The text was updated successfully, but these errors were encountered: