Skip to content

[RFC] Change Resources/meta/LICENSE and Resources/doc/index.rst #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tobion opened this issue Oct 18, 2014 · 5 comments
Closed

[RFC] Change Resources/meta/LICENSE and Resources/doc/index.rst #4335

Tobion opened this issue Oct 18, 2014 · 5 comments
Labels
hasPR A Pull Request has already been submitted for this issue.

Comments

@Tobion
Copy link
Contributor

Tobion commented Oct 18, 2014

Currently the best practise for reusable bundles says

The following files are mandatory:
HelloBundle.php;
Resources/meta/LICENSE: The full license for the code;
Resources/doc/index.rst: The root file for the Bundle documentation.
These conventions ensure that automated tools can rely on this default structure to work.

I think it's time to change that. I would propose to simply say there should be

  1. a LICENSE file in the root directory and a license property in composer.json
  2. a README file (in any format, e.g. README.md or README.rst) in the root directory that serves as an entry point to the documentation

I think this has several advantages:

  1. this is how Symfony itself is also structured. For example, the documentation of symfony bundles is not in Resources/doc but in a separate repository. So symfony does not follow it's own best practises at the moment.
  2. the LICENSE file in the root is common practise in open source but Resources/meta/LICENSE is not
  3. the README is also common practise, especially when using github. This also makes it independent of the format. And most bundles don't use rst format anyway from my experience but markdown, e.g. FosUserBundle. Which would also go against the current best practise.
@Tobion
Copy link
Contributor Author

Tobion commented Oct 18, 2014

Are there actually automated tools that really rely on the current best practise folder structure?

@wouterj
Copy link
Member

wouterj commented Oct 18, 2014

@Tobion
Copy link
Contributor Author

Tobion commented Oct 18, 2014

They don't rely on the folder structure but help you set it up. So the changed wording I chose still permits you to put your documentation in Resources/doc but you can also chose anything else. Because all that matters, is that it should be reachable by the root readme. Btw, gnugat/fossil also creates markdown doc AFAIK so would also now follow the current best practise.

@stof
Copy link
Member

stof commented Nov 7, 2014

To complete this, KnpBundles supports both locations for the LICENSE file (and if both exist, it prefers the root file). And for the README, it supports any extension (given it uses the dedicated github API to retrieve the readme file), but then renders it as markdown

@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label May 2, 2015
@wouterj wouterj closed this as completed Jul 29, 2015
@wouterj
Copy link
Member

wouterj commented Jul 29, 2015

The standards are now made more flexible, allowing both locations for the LICENSE file and both rst and markdown for the README file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Development

No branches or pull requests

3 participants