-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[RFC] Change Resources/meta/LICENSE and Resources/doc/index.rst #4335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are there actually automated tools that really rely on the current best practise folder structure? |
Yes: https://github.com/schmittjoh/JMSCommandBundle and https://github.com/gnugat/fossil are the ones I know. |
They don't rely on the folder structure but help you set it up. So the changed wording I chose still permits you to put your documentation in Resources/doc but you can also chose anything else. Because all that matters, is that it should be reachable by the root readme. Btw, gnugat/fossil also creates markdown doc AFAIK so would also now follow the current best practise. |
To complete this, KnpBundles supports both locations for the LICENSE file (and if both exist, it prefers the root file). And for the README, it supports any extension (given it uses the dedicated github API to retrieve the readme file), but then renders it as markdown |
The standards are now made more flexible, allowing both locations for the LICENSE file and both rst and markdown for the README file |
Currently the best practise for reusable bundles says
I think it's time to change that. I would propose to simply say there should be
I think this has several advantages:
rst
format anyway from my experience but markdown, e.g. FosUserBundle. Which would also go against the current best practise.The text was updated successfully, but these errors were encountered: