Skip to content

Commit b143754

Browse files
committed
bug #4744 [Book][Security] Update code example to fit description (xelaris)
This PR was merged into the 2.6 branch. Discussion ---------- [Book][Security] Update code example to fit description | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | >=2.6 | Fixed tickets | The text mentions an `$encoder` object, which wasn't created in the code example. In addition, I think the paragraph > The ``$encoder`` object also has an ``isPasswordValid`` method, which takes > the ``User`` object as the first argument and the plain password to check > as the second argument. is also applicable to the 2.3 version (https://github.com/symfony/symfony-docs/blob/2.3/book/security.rst#dynamically-encoding-a-password), where the code example already provides an `$encoder` variable. Should I add it there? Commits ------- bd34c6b Update code example to fit description
2 parents c810c69 + bd34c6b commit b143754

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

book/security.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1174,8 +1174,8 @@ in the following way from a controller::
11741174
// whatever *your* User object is
11751175
$user = new AppBundle\Entity\User();
11761176
$plainPassword = 'ryanpass';
1177-
$encoded = $this->container->get('security.password_encoder')
1178-
->encodePassword($user, $plainPassword);
1177+
$encoder = $this->container->get('security.password_encoder');
1178+
$encoded = $encoder->encodePassword($user, $plainPassword);
11791179

11801180
$user->setPassword($encoded);
11811181

0 commit comments

Comments
 (0)