You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
minor #5652 Do not use dynamic REQUEST_URI from $_SERVER as base url (senkal)
This PR was merged into the 2.3 branch.
Discussion
----------
Do not use dynamic REQUEST_URI from $_SERVER as base url
| Q | A
| ------------- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | 2.3
| Fixed tickets |
I am not sure why we use `$_SERVER['REQUEST_URI']` as a first parameter for `Symfony\Component\Routing\RequestContext` where it expects to get baseUrl.
`$_SERVER['REQUEST_URI'] ` is dynamic and shouldn't be used as a static value for baseUrl.
Probably better not to pass this parameter at all(default) or use `/`, what I propose.
I know that many people won't look that deeply into those examples but, in my opinion, `$_SERVER['REQUEST_URI'] ` is not base url.
Not sure what to do with the note about the request uri(the one with http foundation link/info).
Maybe the idea was to use `$_SERVER['REQUEST_URI']` in `->match()` examples ?
Commits
-------
dadefb6 Od not use dynamic REQUEST_URI from $_SERVER as base url
0 commit comments