Skip to content

Configure AuthorizationAdvisoryProxyFactory Immutably #16922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Apr 10, 2025 · 1 comment
Closed

Configure AuthorizationAdvisoryProxyFactory Immutably #16922

jzheaux opened this issue Apr 10, 2025 · 1 comment
Assignees
@jzheaux
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Milestone
6.5.0-RC1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Apr 10, 2025

Initially when adding @AuthorizeReturnObject, AuthorizationAdvisoryProxyFactory was mutable in order to handle the cyclic relationship between AuthorizationAdvisoryProxyFactory and AuthorizeReturnObjectMethodInterceptor.

This mutability has contributed to #16819 and other issues. We should find a way to simplify construction of the proxy factory in such a way that mutating its state is not needed.

Note that this will deprecate addAdvisors.
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement labels Apr 10, 2025
@jzheaux jzheaux self-assigned this Apr 10, 2025
@jzheaux jzheaux added this to the 6.5.0-RC1 milestone Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Milestone
6.5.0-RC1
Development

No branches or pull requests
1 participant
@jzheaux