change return value of AggregateReader to List

schauder · schauder · commit 1e63e31c120c · 2023-09-25T10:09:37.000+02:00
diff --git a/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/AggregateReader.java b/spring-data-jdbc/src/main/java/org/springframework/data/jdbc/core/convert/AggregateReader.java
@@ -86,7 +86,7 @@ public T findById(Object id) {
 		return jdbcTemplate.query(sqlGenerator.findById(), Map.of("id", id), this::extractZeroOrOne);
 	}
 
-	public Iterable<T> findAllById(Iterable<?> ids) {
+	public List<T> findAllById(Iterable<?> ids) {
 
 		List<Object> convertedIds = new ArrayList<>();
 		for (Object id : ids) {
@@ -96,7 +96,7 @@ public Iterable<T> findAllById(Iterable<?> ids) {
 		return jdbcTemplate.query(sqlGenerator.findAllById(), Map.of("ids", convertedIds), this::extractAll);
 	}
 
-	public Iterable<T> findAllBy(Query query) {
+	public List<T> findAllBy(Query query) {
 
 		MapSqlParameterSource parameterSource = new MapSqlParameterSource();
 		BiFunction<Table, RelationalPersistentEntity, Condition> condition = createConditionSource(query, parameterSource);

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public T findById(Object id) {`
`86`	`86`	`return jdbcTemplate.query(sqlGenerator.findById(), Map.of("id", id), this::extractZeroOrOne);`
`87`	`87`	`}`
`88`	`88`
`89`		`- public Iterable<T> findAllById(Iterable<?> ids) {`
	`89`	`+ public List<T> findAllById(Iterable<?> ids) {`
`90`	`90`
`91`	`91`	`List<Object> convertedIds = new ArrayList<>();`
`92`	`92`	`for (Object id : ids) {`
`@@ -96,7 +96,7 @@ public Iterable<T> findAllById(Iterable<?> ids) {`
`96`	`96`	`return jdbcTemplate.query(sqlGenerator.findAllById(), Map.of("ids", convertedIds), this::extractAll);`
`97`	`97`	`}`
`98`	`98`
`99`		`- public Iterable<T> findAllBy(Query query) {`
	`99`	`+ public List<T> findAllBy(Query query) {`
`100`	`100`
`101`	`101`	`MapSqlParameterSource parameterSource = new MapSqlParameterSource();`
`102`	`102`	`BiFunction<Table, RelationalPersistentEntity, Condition> condition = createConditionSource(query, parameterSource);`